linux-kernel - Re: [PATCH RESEND 5/5] HID: multitouch: add device ID for Apple Touch Bar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <CB167906-8D50-44AE-B873-DDEA9A370066@gmail.com>
Date: Wed, 26 Mar 2025 19:09:15 +0530
From: Aditya Garg <adityagarg1208@...il.com>
To: Jiri Kosina <jikos@...nel.org>
Cc: Aditya Garg <gargaditya08@...e.com>,
 Benjamin Tissoires <bentiss@...nel.org>, admin@...eit.net,
 benjamin.tissoires@...hat.com, kekrby@...il.com, linux-input@...r.kernel.org,
 linux-kernel@...r.kernel.org, orlandoch.dev@...il.com
Subject: Re: [PATCH RESEND 5/5] HID: multitouch: add device ID for Apple Touch Bar



> On 26 Mar 2025, at 3:24 PM, Jiri Kosina <jikos@...nel.org> wrote:
> 
> On Tue, 25 Mar 2025, Aditya Garg wrote:
> 
>>>>> Yes I can move hid_find_field to the original location as well. But,
>>>>> I would not want to devm_kzalloc as well unnecessarily if the
>>>>> touchbar is in the basic mode instead of drm mode which will cause
>>>>> this -ENODEV to be executed right?
>>>> 
>>>> It shouldn't matter. hid_core calls devres_open_group() before calling
>>>> .probe(), and calls devres_release_group() on failure. So yes, we'll
>>>> allocate a piece of memory and release it after, but it's not something
>>>> uncommon.
>>> 
>>> Fair. I'll send a v2
>> 
>> I've sent a v2 from my gmail address. Outlook is being too fussy these
>> days, so hopefully I don't have to sign off twice using gmail as well as
>> outlook.
> 
> Thanks. Please always make sure that either in the cover letter or in the
> individual patches you otline the differences between individual patch
> submissions.
> 
Sorry about that. I recently switched to git send-email and it took time for me to get familiar with it. Such minor mistakes do happen in such cases. In case a v3 is needed, I'll share the Changelog. For v2 that I sent, changelog is:

v2: keep parse at original location in patch 5 as suggested by Benjamin