linux-kernel - Re: [PATCH] printf: add tests for generic FourCCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PN0PR01MB958842137184723FD29694E7B8A62@PN0PR01MB9588.INDPRD01.PROD.OUTLOOK.COM>
Date: Wed, 26 Mar 2025 00:26:08 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: Kees Cook <kees@...nel.org>
CC: "tamird@...il.com" <tamird@...il.com>, Petr Mladek <pmladek@...e.com>,
	Steven Rostedt <rostedt@...dmis.org>, Andy Shevchenko
	<andriy.shevchenko@...ux.intel.com>, Rasmus Villemoes
	<linux@...musvillemoes.dk>, Sergey Senozhatsky <senozhatsky@...omium.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] printf: add tests for generic FourCCs

> On 26 Mar 2025, at 1:19 AM, Kees Cook <kees@...nel.org> wrote:
> 
> On Fri, Mar 14, 2025 at 03:45:01AM +0000, Aditya Garg wrote:
>> From: Aditya Garg <gargaditya08@...e.com>
>> 
>> Format specifiers for printing generic 32-bit FourCCs were recently added
>> to vsprintf. They are going through the DRM tree alongwith the appletbdrm
>> driver. Since the printf tests are being converted to kunit, this separate
>> patch for the tests should make it easier to rebase when the merge window
>> opens.
>> 
>> Link: https://lore.kernel.org/dri-devel/79FA3F41-FD7A-41D9-852B-D32606AF5EB4@live.com/T/#u
>> Signed-off-by: Aditya Garg <gargaditya08@...e.com>
>> ---
>> lib/tests/printf_kunit.c | 39 ++++++++++++++++++++++++++++++++-------
> 
> Linus has applied the kunit /lib move tree, so this patch can land via
> regular trees now. Who should take it?

For some reason DRM has not taken up the patch set yet, even after approvals.
I assume it's partly because gitlab.freedesktop.org was down for a whole week.
Now that merge window is open, I myself dunno what is gonna happen with those patches.
Also, I doubt DRM wants to take this up later. So, I have 2 options:

1. Just wait a bit more, probably till merge window settles so that DRM can take up those patches and then you take this one up.
2. I'll just send you the non DRM patch, and upstream it via you so that atleast you can get free. Then. I'll tell DRM to just upstream the DRM relevant patch, again after merge windows settles. The patch is anyways a bug fix, rather than something new.

Choice is yours :)
> 
> --
> Kees Cook