linux-kernel - Re: [PATCH 2/2] tpm/tpm_ftpm_tee: use send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-Pu4FhcntnKii61@kernel.org>
Date: Wed, 26 Mar 2025 14:11:12 +0200
From: Jarkko Sakkinen <jarkko@...nel.org>
To: Sumit Garg <sumit.garg@...nel.org>
Cc: Stefano Garzarella <sgarzare@...hat.com>,
	Jason Gunthorpe <jgg@...pe.ca>, linux-kernel@...r.kernel.org,
	Peter Huewe <peterhuewe@....de>, linux-integrity@...r.kernel.org,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	Jens Wiklander <jens.wiklander@...aro.org>
Subject: Re: [PATCH 2/2] tpm/tpm_ftpm_tee: use send_recv() op

On Tue, Mar 25, 2025 at 10:49:38AM +0530, Sumit Garg wrote:
> On Thu, Mar 20, 2025 at 04:24:33PM +0100, Stefano Garzarella wrote:
> > From: Stefano Garzarella <sgarzare@...hat.com>
> > 
> > This driver does not support interrupts, and receiving the response is
> > synchronous with sending the command.
> > 
> > It used an internal buffer to cache the response when .send() is called,
> > and then return it when .recv() is called.
> > 
> > Let's simplify the driver by implementing the new send_recv() op, so that
> > we can also remove the 4KB internal buffer used to cache the response.
> > 
> > Tested-by: Jens Wiklander <jens.wiklander@...aro.org>
> > Signed-off-by: Stefano Garzarella <sgarzare@...hat.com>
> > ---
> > v1:
> > - added Jens' T-b
> > ---
> >  drivers/char/tpm/tpm_ftpm_tee.h |  4 --
> >  drivers/char/tpm/tpm_ftpm_tee.c | 86 ++++++++-------------------------
> >  2 files changed, 21 insertions(+), 69 deletions(-)
> >
> 
> Reviewed-by: Sumit Garg <sumit.garg@...nel.org>

I've knowingly even peeked at these patches because of stuff
in-flight.

Generally speaking I don't see enough value in complicating
callback interface. It's better to handle complications in
the leaves (i.e. dictatorship of majority ;-) ).

BR, Jarkko