linux-kernel - Re: [PATCH 2/2] tpm/tpm_ftpm_tee: use send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z+QQWe/upJuVpU8r@ziepe.ca>
Date: Wed, 26 Mar 2025 11:34:01 -0300
From: Jason Gunthorpe <jgg@...pe.ca>
To: Jarkko Sakkinen <jarkko@...nel.org>
Cc: Sumit Garg <sumit.garg@...nel.org>,
	Stefano Garzarella <sgarzare@...hat.com>,
	linux-kernel@...r.kernel.org, Peter Huewe <peterhuewe@....de>,
	linux-integrity@...r.kernel.org,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	Jens Wiklander <jens.wiklander@...aro.org>
Subject: Re: [PATCH 2/2] tpm/tpm_ftpm_tee: use send_recv() op

On Wed, Mar 26, 2025 at 02:11:12PM +0200, Jarkko Sakkinen wrote:

> Generally speaking I don't see enough value in complicating
> callback interface. It's better to handle complications in
> the leaves (i.e. dictatorship of majority ;-) ).

That is very much not the way most driver subsystems view the
world. We want to pull logical things into the core code and remove
them from drivers to make the drivers simpler and more robust.

The amount of really dumb driver boiler plate that this series
obviously removes is exactly the sort of stuff we should be fixing by
improving the core code.

The callback interface was never really sanely designed, it was just
built around the idea of pulling the timout processing into the core
code for TIS hardware. It should be revised to properly match these
new HW types that don't have this kind of timeout mechanism.

Jason