| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <TYCPR01MB11463C8CCEFEDAF79868E9BBCC3A62@TYCPR01MB11463.jpnprd01.prod.outlook.com> Date: Wed, 26 Mar 2025 02:14:35 +0000 From: "Emi Kisanuki (Fujitsu)" <fj0570is@...itsu.com> To: 'Steven Price' <steven.price@....com>, "'kvm@...r.kernel.org'" <kvm@...r.kernel.org>, "'kvmarm@...ts.linux.dev'" <kvmarm@...ts.linux.dev> CC: 'Catalin Marinas' <catalin.marinas@....com>, 'Marc Zyngier' <maz@...nel.org>, 'Will Deacon' <will@...nel.org>, 'James Morse' <james.morse@....com>, 'Oliver Upton' <oliver.upton@...ux.dev>, 'Suzuki K Poulose' <suzuki.poulose@....com>, 'Zenghui Yu' <yuzenghui@...wei.com>, "'linux-arm-kernel@...ts.infradead.org'" <linux-arm-kernel@...ts.infradead.org>, "'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>, 'Joey Gouly' <joey.gouly@....com>, 'Alexandru Elisei' <alexandru.elisei@....com>, 'Christoffer Dall' <christoffer.dall@....com>, 'Fuad Tabba' <tabba@...gle.com>, "'linux-coco@...ts.linux.dev'" <linux-coco@...ts.linux.dev>, 'Ganapatrao Kulkarni' <gankulkarni@...amperecomputing.com>, 'Gavin Shan' <gshan@...hat.com>, 'Shanker Donthineni' <sdonthineni@...dia.com>, 'Alper Gun' <alpergun@...gle.com>, "'Aneesh Kumar K . V'" <aneesh.kumar@...nel.org> Subject: RE: [PATCH v7 00/45] arm64: Support for Arm CCA in KVM Hi all, I tested Linux-cca cca-host/v7 patch with our Internal simulator based on QEMU (with CCA and MPAM support). A panic occurred when starting Realm, but I don't think this is a problem with the cca-host/v7 patch. The location of the panic is [1]. [1]https://lore.kernel.org/linux-arm-kernel/20241030160317.2528209-4-joey.gouly@arm.com diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c index 44718d0482b3..46ba30d42b9b 100644 --- a/arch/arm64/kernel/cpuinfo.c +++ b/arch/arm64/kernel/cpuinfo.c @@ -478,6 +478,9 @@ static void __cpuinfo_store_cpu(struct cpuinfo_arm64 *info) if (id_aa64pfr0_32bit_el0(info->reg_id_aa64pfr0)) __cpuinfo_store_cpu_32bit(&info->aarch32); + if (id_aa64pfr0_mpam(info->reg_id_aa64pfr0)) + info->reg_mpamidr = read_cpuid(MPAMIDR_EL1); /////// panic occurred here. + cpuinfo_detect_icache_policy(info); } There was no problem with the cca-host/v5 patch (based on v6.12). This panic is caused by accessing MPAMIDR_EL1 when the chip supports MPAM. This functionality was enabled when the cca host patch base version was rebased from v6.12 to v6.13. I am not familiar with TF-A, but I think this maybe a TF-A's bug. Because It seems TF-A sets MPAM3_EL3.TRAPLOWER to 0 during normal guest boot in manage_extensions_nonsecure_per_world function[2]. However, TF-A does not set it to 0 during Realm guest boot in manage_extensions_secure_per_world function. Therefore, a trap occurs against EL3 (TF-A), and it is likely being processed as an invalid instruction (Undef). [2]https://git.codelinaro.org/linaro/dcap/tf-a/trusted-firmware-a/-/blob/cca/v4/lib/el3_runtime/aarch64/context_mgmt.c?ref_type=heads#L702 Best Regards, Emi Kisanuki > Subject: [PATCH v7 00/45] arm64: Support for Arm CCA in KVM > > This series adds support for running protected VMs using KVM under the Arm > Confidential Compute Architecture (CCA). > > The related guest support was merged for v6.14-rc1 so you no longer need that > separately. > > There are several changes since v6, many thanks for the review comments. The > highlights are below, and individual patches have a changelog. > > * Separation of the concepts of RMM granule size and PAGE_SIZE. It's > now possible to run with a host PAGE_SIZE larger than 4k (but see > below). > > * Return with -EFAULT error for KVM_EXIT_MEMORY_FAULT as per the > documentation. > > * Return -EPERM rather than -EINVAL in cases where a realm function is > performed on a non-realm guest. > > * Several improvements to names of functions/defines and other minor > changes following review feedback - thanks! > > Things to note: > > * You will need an updated kvmtool because of the KVM_EXIT_MEMORY_FAULT > change mentioned above. See below for a link. > > * KVM_VCPU_MAX_FEATURES is incremented. *NOTE*: This effectively > exposes the nested virtualisation feature. So this series as it > stands has a dependency on that being finished before it can be > merged. See [2] for more details. > > * The final patch enables the host's page size to be larger than 4k. > The support is all in the previous patches, but there is more work to > do before I consider this ready, specifically: > > - The code to allocate RTTs (stage 2 page tables) for the RMM still > conflates pages and granules. This means that for every RTT an > entire host page is allocated potentially using 16x the required > memory for the RTTs. > > - Having the guest's page size smaller than the host's currently > doesn't work. The issue is the guest needs to know what granulatity > it can transition pages between shared and private. Exactly how > this should work is an open area of discussion. > > - This configuration isn't well tested, I would be unsurprised if > there are major bugs! ;) But a simple Linux guest of the same page > size works. > > The ABI to the RMM (the RMI) is based on RMM v1.0-rel0 specification[1]. > > This series is based on v6.14-rc1. It is also available as a git > repository: > > https://gitlab.arm.com/linux-arm/linux-cca cca-host/v7 > > Work in progress changes for kvmtool are available from the git repository below: > > https://gitlab.arm.com/linux-arm/kvmtool-cca cca/v5 > > [1] https://developer.arm.com/documentation/den0137/1-0rel0/ > [2] > https://lore.kernel.org/r/a7011738-a084-46fa-947f-395d90b37f8b%40arm.com > > Jean-Philippe Brucker (7): > arm64: RME: Propagate number of breakpoints and watchpoints to > userspace > arm64: RME: Set breakpoint parameters through SET_ONE_REG > arm64: RME: Initialize PMCR.N with number counter supported by RMM > arm64: RME: Propagate max SVE vector length from RMM > arm64: RME: Configure max SVE vector length for a Realm > arm64: RME: Provide register list for unfinalized RME RECs > arm64: RME: Provide accurate register list > > Joey Gouly (2): > arm64: rme: allow userspace to inject aborts > arm64: rme: support RSI_HOST_CALL > > Sean Christopherson (1): > KVM: Prepare for handling only shared mappings in mmu_notifier events > > Steven Price (32): > arm64: RME: Handle Granule Protection Faults (GPFs) > arm64: RME: Add SMC definitions for calling the RMM > arm64: RME: Add wrappers for RMI calls > arm64: RME: Check for RME support at KVM init > arm64: RME: Define the user ABI > arm64: RME: ioctls to create and configure realms > arm64: kvm: Allow passing machine type in KVM creation > arm64: RME: RTT tear down > arm64: RME: Allocate/free RECs to match vCPUs > KVM: arm64: vgic: Provide helper for number of list registers > arm64: RME: Support for the VGIC in realms > KVM: arm64: Support timers in realm RECs > arm64: RME: Allow VMM to set RIPAS > arm64: RME: Handle realm enter/exit > arm64: RME: Handle RMI_EXIT_RIPAS_CHANGE > KVM: arm64: Handle realm MMIO emulation > arm64: RME: Allow populating initial contents > arm64: RME: Runtime faulting of memory > KVM: arm64: Handle realm VCPU load > KVM: arm64: Validate register access for a Realm VM > KVM: arm64: Handle Realm PSCI requests > KVM: arm64: WARN on injected undef exceptions > arm64: Don't expose stolen time for realm guests > arm64: RME: Always use 4k pages for realms > arm64: rme: Prevent Device mappings for Realms > arm_pmu: Provide a mechanism for disabling the physical IRQ > arm64: rme: Enable PMU support with a realm guest > kvm: rme: Hide KVM_CAP_READONLY_MEM for realm guests > arm64: kvm: Expose support for private memory > KVM: arm64: Expose KVM_ARM_VCPU_REC to user space > KVM: arm64: Allow activating realms > WIP: Enable support for PAGE_SIZE>4k > > Suzuki K Poulose (3): > kvm: arm64: Include kvm_emulate.h in kvm/arm_psci.h > kvm: arm64: Expose debug HW register numbers for Realm > arm64: rme: Allow checking SVE on VM instance > > Documentation/virt/kvm/api.rst | 3 + > arch/arm64/include/asm/kvm_emulate.h | 40 + > arch/arm64/include/asm/kvm_host.h | 17 +- > arch/arm64/include/asm/kvm_rme.h | 128 ++ > arch/arm64/include/asm/rmi_cmds.h | 508 ++++++++ > arch/arm64/include/asm/rmi_smc.h | 259 ++++ > arch/arm64/include/asm/virt.h | 1 + > arch/arm64/include/uapi/asm/kvm.h | 49 + > arch/arm64/kvm/Kconfig | 1 + > arch/arm64/kvm/Makefile | 3 +- > arch/arm64/kvm/arch_timer.c | 45 +- > arch/arm64/kvm/arm.c | 173 ++- > arch/arm64/kvm/guest.c | 104 +- > arch/arm64/kvm/hypercalls.c | 4 +- > arch/arm64/kvm/inject_fault.c | 5 +- > arch/arm64/kvm/mmio.c | 16 +- > arch/arm64/kvm/mmu.c | 199 ++- > arch/arm64/kvm/pmu-emul.c | 6 + > arch/arm64/kvm/psci.c | 30 + > arch/arm64/kvm/reset.c | 23 +- > arch/arm64/kvm/rme-exit.c | 199 +++ > arch/arm64/kvm/rme.c | 1710 > ++++++++++++++++++++++++++ > arch/arm64/kvm/sys_regs.c | 79 +- > arch/arm64/kvm/vgic/vgic-init.c | 2 +- > arch/arm64/kvm/vgic/vgic-v3.c | 5 + > arch/arm64/kvm/vgic/vgic.c | 54 +- > arch/arm64/mm/fault.c | 31 +- > drivers/perf/arm_pmu.c | 15 + > include/kvm/arm_arch_timer.h | 2 + > include/kvm/arm_pmu.h | 4 + > include/kvm/arm_psci.h | 2 + > include/linux/kvm_host.h | 2 + > include/linux/perf/arm_pmu.h | 5 + > include/uapi/linux/kvm.h | 31 +- > virt/kvm/kvm_main.c | 7 + > 35 files changed, 3658 insertions(+), 104 deletions(-) create mode 100644 > arch/arm64/include/asm/kvm_rme.h create mode 100644 > arch/arm64/include/asm/rmi_cmds.h create mode 100644 > arch/arm64/include/asm/rmi_smc.h create mode 100644 > arch/arm64/kvm/rme-exit.c create mode 100644 arch/arm64/kvm/rme.c > > -- > 2.43.0 > >
Powered by blists - more mailing lists