linux-kernel - Re: [PATCH 4/5] bugs/x86: Augment warnings output by concatenating 'cond_str' with the regular __FILE__ string in _BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-XAtDi8DCNNmrCn@gmail.com>
Date: Thu, 27 Mar 2025 22:18:44 +0100
From: Ingo Molnar <mingo@...nel.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] bugs/x86: Augment warnings output by concatenating
 'cond_str' with the regular __FILE__ string in _BUG_FLAGS()


* Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Thu, 27 Mar 2025 at 02:36, Ingo Molnar <mingo@...nel.org> wrote:
> >
> > BTW., any reason why we go all the trouble with the bug_entry::line u16
> > number, instead of storing it in the bug_entry::file string with a
> > :__LINE__ postfix or so?
> 
> The compiler will happily share the same storage for identical
> strings, so that was an issue: re-using the same memory for the same
> filename being repeated multiple times.

ohhh ... TIL.

> That obviously doesn't work anyway once you add the warning string to 
> it, so that makes that whole argument go away.

Yeah. Explains the +100K increase in .data as well, which was more than 
what I expected.

Thanks,

	Ingo