linux-kernel - Re: [PATCH 0/5] Improve WARN_ON_ONCE() output by adding the condition string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87tt78cb5m.fsf@prevas.dk>
Date: Tue, 01 Apr 2025 14:35:17 +0200
From: Rasmus Villemoes <ravi@...vas.dk>
To: Ingo Molnar <mingo@...nel.org>
Cc: linux-kernel@...r.kernel.org,  Linus Torvalds
 <torvalds@...ux-foundation.org>,  Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH 0/5] Improve WARN_ON_ONCE() output by adding the
 condition string

On Wed, Mar 26 2025, Ingo Molnar <mingo@...nel.org> wrote:

> The cost is about +100K more .data on a defconfig kernel, and no runtime
> code generation impact:
>
>        text       data        bss         dec        hex    filename
>    29523998    7926322    1389904    38840224    250a7a0    vmlinux.x86.defconfig.before
>    29523998    8024626    1389904    38938528    25227a0    vmlinue.x86.defconfig.after
>

That's quite a lot. I don't suppose the condition strings themselves are
responsible for most of that; how much is due to the __FILE__ strings
now no longer being deduplicated/shared between WARN instances in same
file? How much harder would it be to add a new cond_str member to
bug_entry, and how would the numbers look then?

Rasmus