| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <d1eaa67e-3766-46c6-95cb-69cb9e91fc29@stanley.mountain>
Date: Thu, 27 Mar 2025 08:23:20 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: oe-kbuild@...ts.linux.dev, Tomasz Jeznach <tjeznach@...osinc.com>
Cc: lkp@...el.com, oe-kbuild-all@...ts.linux.dev,
linux-kernel@...r.kernel.org, Joerg Roedel <jroedel@...e.de>,
Nick Kossifidis <mick@....forth.gr>,
Sebastien Boeuf <seb@...osinc.com>,
Lu Baolu <baolu.lu@...ux.intel.com>
Subject: drivers/iommu/riscv/iommu-platform.c:54 riscv_iommu_platform_probe()
warn: 'iommu->irqs_count' unsigned <= 0
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: f6e0150b2003fb2b9265028a618aa1732b3edc8f
commit: 5c0ebbd3c6c6e00af112fe053e81ac0c7cafe647 iommu/riscv: Add RISC-V IOMMU platform device driver
date: 5 months ago
config: riscv-randconfig-r072-20250327 (https://download.01.org/0day-ci/archive/20250327/202503270710.nzXdpHfG-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project c2692afc0a92cd5da140dfcdfff7818a5b8ce997)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
| Closes: https://lore.kernel.org/r/202503270710.nzXdpHfG-lkp@intel.com/
smatch warnings:
drivers/iommu/riscv/iommu-platform.c:54 riscv_iommu_platform_probe() warn: 'iommu->irqs_count' unsigned <= 0
vim +54 drivers/iommu/riscv/iommu-platform.c
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 20 static int riscv_iommu_platform_probe(struct platform_device *pdev)
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 21 {
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 22 struct device *dev = &pdev->dev;
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 23 struct riscv_iommu_device *iommu = NULL;
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 24 struct resource *res = NULL;
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 25 int vec;
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 26
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 27 iommu = devm_kzalloc(dev, sizeof(*iommu), GFP_KERNEL);
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 28 if (!iommu)
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 29 return -ENOMEM;
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 30
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 31 iommu->dev = dev;
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 32 iommu->reg = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 33 if (IS_ERR(iommu->reg))
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 34 return dev_err_probe(dev, PTR_ERR(iommu->reg),
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 35 "could not map register region\n");
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 36
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 37 dev_set_drvdata(dev, iommu);
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 38
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 39 /* Check device reported capabilities / features. */
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 40 iommu->caps = riscv_iommu_readq(iommu, RISCV_IOMMU_REG_CAPABILITIES);
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 41 iommu->fctl = riscv_iommu_readl(iommu, RISCV_IOMMU_REG_FCTL);
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 42
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 43 /* For now we only support WSI */
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 44 switch (FIELD_GET(RISCV_IOMMU_CAPABILITIES_IGS, iommu->caps)) {
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 45 case RISCV_IOMMU_CAPABILITIES_IGS_WSI:
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 46 case RISCV_IOMMU_CAPABILITIES_IGS_BOTH:
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 47 break;
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 48 default:
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 49 return dev_err_probe(dev, -ENODEV,
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 50 "unable to use wire-signaled interrupts\n");
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 51 }
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 52
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 53 iommu->irqs_count = platform_irq_count(pdev);
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 @54 if (iommu->irqs_count <= 0)
^^^^^^^^^^^^^^^^^^^^^^
Unsigned can't be less than zero. platform_irq_count() returns
-EPROBE_DEFER on error.
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 55 return dev_err_probe(dev, -ENODEV,
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 56 "no IRQ resources provided\n");
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 57 if (iommu->irqs_count > RISCV_IOMMU_INTR_COUNT)
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 58 iommu->irqs_count = RISCV_IOMMU_INTR_COUNT;
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 59
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 60 for (vec = 0; vec < iommu->irqs_count; vec++)
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 61 iommu->irqs[vec] = platform_get_irq(pdev, vec);
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 62
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 63 /* Enable wire-signaled interrupts, fctl.WSI */
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 64 if (!(iommu->fctl & RISCV_IOMMU_FCTL_WSI)) {
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 65 iommu->fctl |= RISCV_IOMMU_FCTL_WSI;
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 66 riscv_iommu_writel(iommu, RISCV_IOMMU_REG_FCTL, iommu->fctl);
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 67 }
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 68
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 69 return riscv_iommu_init(iommu);
5c0ebbd3c6c6e0 Tomasz Jeznach 2024-10-15 70 };
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists