linux-kernel - Re: [PATCH] iomap: Rename iomap_last_written_block to iomap_first_unchanged

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-Up3xt1q9swlhv_@infradead.org>
Date: Thu, 27 Mar 2025 03:35:11 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Chi Zhiling <chizhiling@....com>
Cc: cem@...nel.org, djwong@...nel.org, brauner@...nel.org,
	linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, Chi Zhiling <chizhiling@...inos.cn>
Subject: Re: [PATCH] iomap: Rename iomap_last_written_block to
 iomap_first_unchanged_block

On Thu, Mar 27, 2025 at 01:57:06PM +0800, Chi Zhiling wrote:
> From: Chi Zhiling <chizhiling@...inos.cn>
> 
> This renames iomap_last_written_block() to iomap_first_unchanged_block()
> to better reflect its actual behavior of finding the first unmodified
> block after partial writes, improving code readability.

Does it?  I it used in the context of a write operation where uncached
is not exactly well define.  I'm not a native speaker, but I don't see
an improvement here (then again I picked the current name, so I might be
biassed).

> +static inline loff_t iomap_first_unchanged_block(struct inode *inode, loff_t pos,

Either way please avoid the overly long line.