linux-kernel - Re: [PATCH] iomap: Rename iomap_last_written_block to iomap_first_unchanged

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <af42c4fb-925a-4c3f-b54e-a07dff8bb168@163.com>
Date: Thu, 27 Mar 2025 19:46:24 +0800
From: Chi Zhiling <chizhiling@....com>
To: Christoph Hellwig <hch@...radead.org>
Cc: cem@...nel.org, djwong@...nel.org, brauner@...nel.org,
 linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-fsdevel@...r.kernel.org, Chi Zhiling <chizhiling@...inos.cn>
Subject: Re: [PATCH] iomap: Rename iomap_last_written_block to
 iomap_first_unchanged_block

On 2025/3/27 18:35, Christoph Hellwig wrote:
> On Thu, Mar 27, 2025 at 01:57:06PM +0800, Chi Zhiling wrote:
>> From: Chi Zhiling <chizhiling@...inos.cn>
>>
>> This renames iomap_last_written_block() to iomap_first_unchanged_block()
>> to better reflect its actual behavior of finding the first unmodified
>> block after partial writes, improving code readability.
> 
> Does it?  I it used in the context of a write operation where uncached
> is not exactly well define.  I'm not a native speaker, but I don't see
> an improvement here (then again I picked the current name, so I might be
> biassed).

Okay, actually 'last_written_block' also makes sense, it's just that it 
returns the end of the last written block, not the beginning


thanks,
Chi Zhiling