| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAJZ5v0h=6Aa1oqkxEt1LOaF+YUuaB9i3jjy6RqhEfPm-3PVWyw@mail.gmail.com>
Date: Thu, 27 Mar 2025 13:27:10 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>,
Dan Williams <dan.j.williams@...el.com>, Jonathan Cameron <Jonathan.Cameron@...wei.com>,
Alison Schofield <alison.schofield@...el.com>, Robert Richter <rrichter@....com>,
Bruno Faccini <bfaccini@...dia.com>, Haibo Xu <haibo1.xu@...el.com>,
Dave Jiang <dave.jiang@...el.com>, "Mike Rapoport (Microsoft)" <rppt@...nel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, linux-acpi@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] ACPI: NUMA: Use str_enabled_disabled() helper function
On Tue, Mar 11, 2025 at 12:43 PM Thorsten Blum <thorsten.blum@...ux.dev> wrote:
>
> Remove hard-coded strings by using the str_enabled_disabled() helper
> function.
>
> Acked-by: Bruno Faccini <bfaccini@...dia.com>
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
> drivers/acpi/numa/srat.c | 22 ++++++++--------------
> 1 file changed, 8 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c
> index 00ac0d7bb8c9..ac7045f3b85b 100644
> --- a/drivers/acpi/numa/srat.c
> +++ b/drivers/acpi/numa/srat.c
> @@ -18,6 +18,7 @@
> #include <linux/nodemask.h>
> #include <linux/topology.h>
> #include <linux/numa_memblks.h>
> +#include <linux/string_choices.h>
>
> static nodemask_t nodes_found_map = NODE_MASK_NONE;
>
> @@ -187,8 +188,7 @@ acpi_table_print_srat_entry(struct acpi_subtable_header *header)
> pr_debug("SRAT Processor (id[0x%02x] eid[0x%02x]) in proximity domain %d %s\n",
> p->apic_id, p->local_sapic_eid,
> p->proximity_domain_lo,
> - (p->flags & ACPI_SRAT_CPU_ENABLED) ?
> - "enabled" : "disabled");
> + str_enabled_disabled(p->flags & ACPI_SRAT_CPU_ENABLED));
> }
> break;
>
> @@ -200,8 +200,7 @@ acpi_table_print_srat_entry(struct acpi_subtable_header *header)
> (unsigned long long)p->base_address,
> (unsigned long long)p->length,
> p->proximity_domain,
> - (p->flags & ACPI_SRAT_MEM_ENABLED) ?
> - "enabled" : "disabled",
> + str_enabled_disabled(p->flags & ACPI_SRAT_MEM_ENABLED),
> (p->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) ?
> " hot-pluggable" : "",
> (p->flags & ACPI_SRAT_MEM_NON_VOLATILE) ?
> @@ -216,8 +215,7 @@ acpi_table_print_srat_entry(struct acpi_subtable_header *header)
> pr_debug("SRAT Processor (x2apicid[0x%08x]) in proximity domain %d %s\n",
> p->apic_id,
> p->proximity_domain,
> - (p->flags & ACPI_SRAT_CPU_ENABLED) ?
> - "enabled" : "disabled");
> + str_enabled_disabled(p->flags & ACPI_SRAT_CPU_ENABLED));
> }
> break;
>
> @@ -228,8 +226,7 @@ acpi_table_print_srat_entry(struct acpi_subtable_header *header)
> pr_debug("SRAT Processor (acpi id[0x%04x]) in proximity domain %d %s\n",
> p->acpi_processor_uid,
> p->proximity_domain,
> - (p->flags & ACPI_SRAT_GICC_ENABLED) ?
> - "enabled" : "disabled");
> + str_enabled_disabled(p->flags & ACPI_SRAT_GICC_ENABLED));
> }
> break;
>
> @@ -247,8 +244,7 @@ acpi_table_print_srat_entry(struct acpi_subtable_header *header)
> *(u16 *)(&p->device_handle[0]),
> *(u16 *)(&p->device_handle[2]),
> p->proximity_domain,
> - (p->flags & ACPI_SRAT_GENERIC_AFFINITY_ENABLED) ?
> - "enabled" : "disabled");
> + str_enabled_disabled(p->flags & ACPI_SRAT_GENERIC_AFFINITY_ENABLED));
> } else {
> /*
> * In this case we can rely on the device having a
> @@ -258,8 +254,7 @@ acpi_table_print_srat_entry(struct acpi_subtable_header *header)
> (char *)(&p->device_handle[0]),
> (char *)(&p->device_handle[8]),
> p->proximity_domain,
> - (p->flags & ACPI_SRAT_GENERIC_AFFINITY_ENABLED) ?
> - "enabled" : "disabled");
> + str_enabled_disabled(p->flags & ACPI_SRAT_GENERIC_AFFINITY_ENABLED));
> }
> }
> break;
> @@ -271,8 +266,7 @@ acpi_table_print_srat_entry(struct acpi_subtable_header *header)
> pr_debug("SRAT Processor (acpi id[0x%04x]) in proximity domain %d %s\n",
> p->acpi_processor_uid,
> p->proximity_domain,
> - (p->flags & ACPI_SRAT_RINTC_ENABLED) ?
> - "enabled" : "disabled");
> + str_enabled_disabled(p->flags & ACPI_SRAT_RINTC_ENABLED));
> }
> break;
>
> --
Applied as 6.15-rc material, thanks!
Powered by blists - more mailing lists