linux-kernel - Re: [Intel-wired-lan] [PATCH net-next] igc: Fix TX drops in XDP ZC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0f2227e3-10f5-4915-be92-e130a875fc67@intel.com>
Date: Thu, 27 Mar 2025 15:07:08 +0200
From: Mor Bar-Gabay <morx.bar.gabay@...el.com>
To: Zdenek Bouska <zdenek.bouska@...mens.com>, Tony Nguyen
	<anthony.l.nguyen@...el.com>, Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>, Alexei Starovoitov <ast@...nel.org>, "Daniel
 Borkmann" <daniel@...earbox.net>, Jesper Dangaard Brouer <hawk@...nel.org>,
	John Fastabend <john.fastabend@...il.com>, Andre Guedes
	<andre.guedes@...el.com>, Vedang Patel <vedang.patel@...el.com>, "Maciej
 Fijalkowski" <maciej.fijalkowski@...el.com>, Jithu Joseph
	<jithu.joseph@...el.com>, Song Yoong Siang <yoong.siang.song@...el.com>,
	Florian Bezdeka <florian.bezdeka@...mens.com>
CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <bpf@...r.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH net-next] igc: Fix TX drops in XDP ZC

On 19/03/2025 16:18, Zdenek Bouska wrote:
> Fixes TX frame drops in AF_XDP zero copy mode when budget < 4.
> xsk_tx_peek_desc() consumed TX frame and it was ignored because of
> low budget. Not even AF_XDP completion was done for dropped frames.
> 
> It can be reproduced on i226 by sending 100000x 60 B frames with
> launch time set to minimal IPG (672 ns between starts of frames)
> on 1Gbit/s. Always 1026 frames are not sent and are missing a
> completion.
> 
> Fixes: 9acf59a752d4c ("igc: Enable TX via AF_XDP zero-copy")
> Signed-off-by: Zdenek Bouska <zdenek.bouska@...mens.com>
> Reviewed-by: Song Yoong Siang <yoong.siang.song@...el.com>
> Reviewed-by: Florian Bezdeka <florian.bezdeka@...mens.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
Tested-by: Mor Bar-Gabay <morx.bar.gabay@...el.com>