lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250327141316.GBZ-Vc_NybN1cIEePu@fat_crate.local>
Date: Thu, 27 Mar 2025 15:13:16 +0100
From: Borislav Petkov <bp@...en8.de>
To: Jürgen Groß <jgross@...e.com>
Cc: Jan Beulich <jbeulich@...e.com>, oe-kbuild-all@...ts.linux.dev,
	xen-devel@...ts.xenproject.org,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>,
	kernel test robot <lkp@...el.com>, x86-ml <x86@...nel.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [xen-tip:linux-next 12/12] WARNING: modpost: vmlinux: section
 mismatch in reference: mc_debug_data+0x0 (section: .data) ->
 mc_debug_data_early (section: .init.data)

On Wed, Jul 24, 2024 at 11:55:39AM +0200, Jürgen Groß wrote:
> I'd prefer a general way to handle this problem, like e.g. some kind of
> __refdata tagging for percpu variables.

Any reason for not doing the trivial thing?

diff --git a/arch/x86/xen/multicalls.c b/arch/x86/xen/multicalls.c
index 10c660fae8b3..100bfaba3f4d 100644
--- a/arch/x86/xen/multicalls.c
+++ b/arch/x86/xen/multicalls.c
@@ -53,7 +53,7 @@ struct mc_debug_data {
 };
 
 static DEFINE_PER_CPU(struct mc_buffer, mc_buffer);
-static struct mc_debug_data mc_debug_data_early __initdata;
+static struct mc_debug_data mc_debug_data_early;
 static DEFINE_PER_CPU(struct mc_debug_data *, mc_debug_data) =
 	&mc_debug_data_early;
 static struct mc_debug_data __percpu *mc_debug_data_ptr;

---

since this breaks randbuilds:

WARNING: modpost: vmlinux: section mismatch in reference: mc_debug_data+0x0 (section: .data) -> mc_debug_data_early (section: .init.data)
ERROR: modpost: Section mismatches detected.
Set CONFIG_SECTION_MISMATCH_WARN_ONLY=y to allow them.
make[2]: *** [scripts/Makefile.modpost:147: Module.symvers] Error 1
make[2]: *** Deleting file 'Module.symvers'
make[1]: *** [/mnt/kernel/kernel/linux/Makefile:1947: modpost] Error 2
make: *** [Makefile:251: __sub-make] Error 2

?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ