linux-kernel - Re: [xen-tip:linux-next 12/12] WARNING: modpost: vmlinux: section mismatch in reference: mc_debug_data+0x0 (section: .data) -> mc_debug_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c18a543c-4df2-4744-bf16-e888a832d634@suse.com>
Date: Thu, 27 Mar 2025 15:21:45 +0100
From: Jürgen Groß <jgross@...e.com>
To: Borislav Petkov <bp@...en8.de>
Cc: Jan Beulich <jbeulich@...e.com>, oe-kbuild-all@...ts.linux.dev,
 xen-devel@...ts.xenproject.org, Boris Ostrovsky
 <boris.ostrovsky@...cle.com>, kernel test robot <lkp@...el.com>,
 x86-ml <x86@...nel.org>, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [xen-tip:linux-next 12/12] WARNING: modpost: vmlinux: section
 mismatch in reference: mc_debug_data+0x0 (section: .data) ->
 mc_debug_data_early (section: .init.data)

On 27.03.25 15:13, Borislav Petkov wrote:
> On Wed, Jul 24, 2024 at 11:55:39AM +0200, Jürgen Groß wrote:
>> I'd prefer a general way to handle this problem, like e.g. some kind of
>> __refdata tagging for percpu variables.
> 
> Any reason for not doing the trivial thing?
> 
> diff --git a/arch/x86/xen/multicalls.c b/arch/x86/xen/multicalls.c
> index 10c660fae8b3..100bfaba3f4d 100644
> --- a/arch/x86/xen/multicalls.c
> +++ b/arch/x86/xen/multicalls.c
> @@ -53,7 +53,7 @@ struct mc_debug_data {
>   };
>   
>   static DEFINE_PER_CPU(struct mc_buffer, mc_buffer);
> -static struct mc_debug_data mc_debug_data_early __initdata;
> +static struct mc_debug_data mc_debug_data_early;
>   static DEFINE_PER_CPU(struct mc_debug_data *, mc_debug_data) =
>   	&mc_debug_data_early;
>   static struct mc_debug_data __percpu *mc_debug_data_ptr;

Well, that is wasting nearly 3kB of the data section.

Maybe not a big deal, but still...


Juergen

Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3684 bytes)

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (496 bytes)