[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6a487a73-3f2d-4373-8e02-ba749181bdfb@kernel.org>
Date: Thu, 27 Mar 2025 15:15:19 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Manikandan Karunakaran Pillai <mpillai@...ence.com>,
"bhelgaas@...gle.com" <bhelgaas@...gle.com>,
"lpieralisi@...nel.org" <lpieralisi@...nel.org>, "kw@...ux.com"
<kw@...ux.com>,
"manivannan.sadhasivam@...aro.org" <manivannan.sadhasivam@...aro.org>,
"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>
Cc: "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/7] dt-bindings: pci: cadence: Extend compatible for new
platform configurations
On 27/03/2025 12:19, Manikandan Karunakaran Pillai wrote:
> Document the compatible property for the newly added values for PCIe EP and
> RP configurations. Fix the compilation issues that came up for the existing
> Cadence bindings
These are two different commits.
>
> Signed-off-by: Manikandan K Pillai <mpillai@...ence.com>
> ---
> .../bindings/pci/cdns,cdns-pcie-ep.yaml | 12 +-
> .../bindings/pci/cdns,cdns-pcie-host.yaml | 119 +++++++++++++++---
> 2 files changed, 110 insertions(+), 21 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml
> index 98651ab22103..aa4ad69a9b71 100644
> --- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml
> @@ -7,14 +7,22 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
> title: Cadence PCIe EP Controller
>
> maintainers:
> - - Tom Joseph <tjoseph@...ence.com>
> + - Manikandan K Pillai <mpillai@...ence.com>
>
> allOf:
> - $ref: cdns-pcie-ep.yaml#
>
> properties:
> compatible:
> - const: cdns,cdns-pcie-ep
> + oneOf:
> + - const: cdns,cdns-pcie-ep
> + - const: cdns,cdns-pcie-hpa-ep
What is hpa? Which soc is that?
I don't think this should keep growing, but instead use SoC based
compatibles.
Anyway, that's enum.
> + - const: cdns,cdns-cix-pcie-hpa-ep
What is cix? If you want to stuff here soc in the middle, then no, no
no. Please read devicetree spec and writing bindings how the compatibles
are created.
> + - description: PCIe EP controller from cadence
> + items:
> + - const: cdns,cdns-pcie-ep
> + - const: cdns,cdns-pcie-hpa-ep
> + - const: cdns,cdns-cix-pcie-hpa-ep
This makes no sense.
>
> reg:
> maxItems: 2
> diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.yaml b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.yaml
> index a8190d9b100f..bb7ffb9ddaf9 100644
> --- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.yaml
> @@ -7,16 +7,30 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
> title: Cadence PCIe host controller
>
> maintainers:
> - - Tom Joseph <tjoseph@...ence.com>
> + - Manikandan K Pillai <mpillai@...ence.com>
>
> allOf:
> - - $ref: cdns-pcie-host.yaml#
> + - $ref: cdns-pcie.yaml#
Why?
>
> properties:
> + "#size-cells":
> + const: 2
> + "#address-cells":
> + const: 3
Huh? Why? Nothing here makes sense.
Best regards,
Krzysztof
Powered by blists - more mailing lists