linux-kernel - Re: [PATCH] m68k/mvme147: Don't unregister boot console needlessly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b8150223-8bce-32fb-c146-e14bcaa91134@linux-m68k.org>
Date: Sat, 29 Mar 2025 09:25:28 +1100 (AEDT)
From: Finn Thain <fthain@...ux-m68k.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
cc: Daniel Palmer <daniel@...f.com>, linux-m68k@...ts.linux-m68k.org, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH] m68k/mvme147: Don't unregister boot console needlessly

On Fri, 28 Mar 2025, Geert Uytterhoeven wrote:

> > --- a/arch/m68k/kernel/early_printk.c
> > +++ b/arch/m68k/kernel/early_printk.c
> > @@ -60,7 +60,7 @@ early_param("earlyprintk", setup_early_printk);
> >
> >  static int __init unregister_early_console(void)
> >  {
> > -       if (!early_console || MACH_IS_MVME16x)
> > +       if (!early_console || MACH_IS_MVME147 || MACH_IS_MVME16x)
> >                 return 0;
> >
> >         return unregister_console(early_console);
> 
> Perhaps the whole function and the late_initcall() can just be removed?
> 

A comment in arch/m68k/kernel/early_printk.c gives the reason why that 
code exists: debug_cons_nputs() lives in .init.text. Platforms like MVME 
which don't use that function to implement earlyprintk don't have to worry 
about this.

I suppose MACH_IS_FOO is not a great way to encode that requirement. But 
it don't think it has to be self-documenting. It does have to be 
consistent with the conditionals in head.S.