linux-kernel - Re: [PATCH] selftests/nolibc: drop unnecessary sys/io.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76eb91c8-4c66-4e2a-8d32-f2e5d545bb74@linuxfoundation.org>
Date: Fri, 28 Mar 2025 16:23:38 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Thomas Weißschuh <linux@...ssschuh.net>,
 Willy Tarreau <w@....eu>, Shuah Khan <shuah@...nel.org>
Cc: linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 Sebastian Andrzej Siewior <sebastian@...akpoint.cc>,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests/nolibc: drop unnecessary sys/io.h include

On 3/24/25 16:01, Thomas Weißschuh wrote:
> The include of sys/io.h is not necessary anymore since
> commit 67eb617a8e1e ("selftests/nolibc: simplify call to ioperm").
> It's existence is also problematic as the header does not exist on all
> architectures.
> 
> Reported-by: Sebastian Andrzej Siewior <sebastian@...akpoint.cc>
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> ---
>   tools/testing/selftests/nolibc/nolibc-test.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c
> index 5884a891c491544050fc35b07322c73a1a9dbaf3..7a60b6ac1457e8d862ab1a6a26c9e46abec92111 100644
> --- a/tools/testing/selftests/nolibc/nolibc-test.c
> +++ b/tools/testing/selftests/nolibc/nolibc-test.c
> @@ -16,7 +16,6 @@
>   #ifndef _NOLIBC_STDIO_H
>   /* standard libcs need more includes */
>   #include <sys/auxv.h>
> -#include <sys/io.h>
>   #include <sys/ioctl.h>
>   #include <sys/mman.h>
>   #include <sys/mount.h>
> 
> ---
> base-commit: bceb73904c855c78402dca94c82915f078f259dd
> change-id: 20250324-nolibc-ioperm-155646560b95
> 
> Best regards,

Acked-by: Shuah Khan <skhan@...uxfoundation.org>

thanks,
-- Shuah