linux-kernel - Re: [PATCH] selftests/nolibc: drop unnecessary sys/io.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250329154347.GA11338@1wt.eu>
Date: Sat, 29 Mar 2025 16:43:47 +0100
From: Willy Tarreau <w@....eu>
To: Shuah Khan <skhan@...uxfoundation.org>
Cc: Thomas Weißschuh <linux@...ssschuh.net>,
        Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Sebastian Andrzej Siewior <sebastian@...akpoint.cc>
Subject: Re: [PATCH] selftests/nolibc: drop unnecessary sys/io.h include

On Fri, Mar 28, 2025 at 04:23:38PM -0600, Shuah Khan wrote:
> On 3/24/25 16:01, Thomas Weißschuh wrote:
> > The include of sys/io.h is not necessary anymore since
> > commit 67eb617a8e1e ("selftests/nolibc: simplify call to ioperm").
> > It's existence is also problematic as the header does not exist on all
> > architectures.
> > 
> > Reported-by: Sebastian Andrzej Siewior <sebastian@...akpoint.cc>
> > Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> > ---
> >   tools/testing/selftests/nolibc/nolibc-test.c | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c
> > index 5884a891c491544050fc35b07322c73a1a9dbaf3..7a60b6ac1457e8d862ab1a6a26c9e46abec92111 100644
> > --- a/tools/testing/selftests/nolibc/nolibc-test.c
> > +++ b/tools/testing/selftests/nolibc/nolibc-test.c
> > @@ -16,7 +16,6 @@
> >   #ifndef _NOLIBC_STDIO_H
> >   /* standard libcs need more includes */
> >   #include <sys/auxv.h>
> > -#include <sys/io.h>
> >   #include <sys/ioctl.h>
> >   #include <sys/mman.h>
> >   #include <sys/mount.h>
> > 
> > ---
> > base-commit: bceb73904c855c78402dca94c82915f078f259dd
> > change-id: 20250324-nolibc-ioperm-155646560b95
> > 
> > Best regards,
> 
> Acked-by: Shuah Khan <skhan@...uxfoundation.org>

Fine for me as well.

Acked-by: Willy Tarreau <w@....eu>

Thanks,
willy