[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250328230219.826726-1-ctshao@google.com>
Date: Fri, 28 Mar 2025 16:01:57 -0700
From: Chun-Tse Shao <ctshao@...gle.com>
To: linux-kernel@...r.kernel.org
Cc: Chun-Tse Shao <ctshao@...gle.com>, Arnaldo Carvalho de Melo <acme@...nel.org>,
Namhyung Kim <namhyung@...nel.org>, peterz@...radead.org, mingo@...hat.com,
mark.rutland@....com, alexander.shishkin@...ux.intel.com, jolsa@...nel.org,
irogers@...gle.com, adrian.hunter@...el.com, kan.liang@...ux.intel.com,
dvyukov@...gle.com, ben.gainey@....com, linux-perf-users@...r.kernel.org
Subject: [PATCH v1] perf report: Skip unsupported new event types
`perf report` currently halts with an error when encountering
unsupported new event types (`event.type >= PERF_RECORD_HEADER_MAX`).
This patch modifies the behavior to skip these samples and continue
processing the remaining events.
Signed-off-by: Chun-Tse Shao <ctshao@...gle.com>
Suggested-by: Arnaldo Carvalho de Melo <acme@...nel.org>
Suggested-by: Namhyung Kim <namhyung@...nel.org>
---
tools/perf/util/session.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index 60fb9997ea0d..d58fc1ed2fdf 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -1639,8 +1639,13 @@ static s64 perf_session__process_event(struct perf_session *session,
if (session->header.needs_swap)
event_swap(event, evlist__sample_id_all(evlist));
- if (event->header.type >= PERF_RECORD_HEADER_MAX)
- return -EINVAL;
+ if (event->header.type >= PERF_RECORD_HEADER_MAX) {
+ /* This perf is outdated and does not support the latest event type. */
+ ui__warning("Unsupported type %u, please considering update perf.\n",
+ event->header.type);
+ /* Skip the supported event by returning its size. */
+ return event->header.size;
+ }
events_stats__inc(&evlist->stats, event->header.type);
--
2.49.0.472.ge94155a9ec-goog
Powered by blists - more mailing lists