linux-kernel - Re: [PATCH v1] perf report: Skip unsupported new event types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z-dBUbCqjGtMg2RS@google.com>
Date: Fri, 28 Mar 2025 17:39:45 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Chun-Tse Shao <ctshao@...gle.com>
Cc: linux-kernel@...r.kernel.org,
	Arnaldo Carvalho de Melo <acme@...nel.org>, peterz@...radead.org,
	mingo@...hat.com, mark.rutland@....com,
	alexander.shishkin@...ux.intel.com, jolsa@...nel.org,
	irogers@...gle.com, adrian.hunter@...el.com,
	kan.liang@...ux.intel.com, dvyukov@...gle.com, ben.gainey@....com,
	linux-perf-users@...r.kernel.org
Subject: Re: [PATCH v1] perf report: Skip unsupported new event types

Hello,

On Fri, Mar 28, 2025 at 04:01:57PM -0700, Chun-Tse Shao wrote:
> `perf report` currently halts with an error when encountering
> unsupported new event types (`event.type >= PERF_RECORD_HEADER_MAX`).
> This patch modifies the behavior to skip these samples and continue
> processing the remaining events.
> 
> Signed-off-by: Chun-Tse Shao <ctshao@...gle.com>
> Suggested-by: Arnaldo Carvalho de Melo <acme@...nel.org>
> Suggested-by: Namhyung Kim <namhyung@...nel.org>
> ---
>  tools/perf/util/session.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> index 60fb9997ea0d..d58fc1ed2fdf 100644
> --- a/tools/perf/util/session.c
> +++ b/tools/perf/util/session.c
> @@ -1639,8 +1639,13 @@ static s64 perf_session__process_event(struct perf_session *session,
>  	if (session->header.needs_swap)
>  		event_swap(event, evlist__sample_id_all(evlist));
>  
> -	if (event->header.type >= PERF_RECORD_HEADER_MAX)
> -		return -EINVAL;
> +	if (event->header.type >= PERF_RECORD_HEADER_MAX) {
> +		/* This perf is outdated and does not support the latest event type. */
> +		ui__warning("Unsupported type %u, please considering update perf.\n",
> +			    event->header.type);
> +		/* Skip the supported event by returning its size. */
> +		return event->header.size;

Please make sure if the size is 8-byte aligned.

Thanks,
Namhyung


> +	}
>  
>  	events_stats__inc(&evlist->stats, event->header.type);
>  
> -- 
> 2.49.0.472.ge94155a9ec-goog
>