linux-kernel - Re: [PATCH v4 1/6] media: v4l2: Add NV15 and NV20 pixel formats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D8SA0W2ZEAQ3.3BO4NMONFJCRC@cknow.org>
Date: Sat, 29 Mar 2025 00:09:37 +0100
From: "Diederik de Haas" <didi.debian@...ow.org>
To: "Detlev Casanova" <detlev.casanova@...labora.com>,
 <linux-media@...r.kernel.org>, <linux-rockchip@...ts.infradead.org>
Cc: "Ezequiel Garcia" <ezequiel@...guardiasur.com.ar>, "Mauro Carvalho
 Chehab" <mchehab@...nel.org>, "Rob Herring" <robh@...nel.org>, "Krzysztof
 Kozlowski" <krzk+dt@...nel.org>, "Conor Dooley" <conor+dt@...nel.org>,
 "Heiko Stuebner" <heiko@...ech.de>, "Greg Kroah-Hartman"
 <gregkh@...uxfoundation.org>, "Hans Verkuil" <hverkuil@...all.nl>, "Nicolas
 Dufresne" <nicolas.dufresne@...labora.com>, "Andrzej Pietrasiewicz"
 <andrzej.p@...labora.com>, "Jonas Karlman" <jonas@...boo.se>, "Sebastian
 Reichel" <sebastian.reichel@...labora.com>, "Niklas Cassel"
 <cassel@...nel.org>, "Alexey Charkov" <alchark@...il.com>, "Dragan Simic"
 <dsimic@...jaro.org>, "Jianfeng Liu" <liujianfeng1994@...il.com>, "Jacopo
 Mondi" <jacopo.mondi@...asonboard.com>, "Sakari Ailus"
 <sakari.ailus@...ux.intel.com>, "Kieran Bingham"
 <kieran.bingham@...asonboard.com>, "Laurent Pinchart"
 <laurent.pinchart@...asonboard.com>, "Umang Jain"
 <umang.jain@...asonboard.com>, "Naushir Patuck" <naush@...pberrypi.com>,
 "Jean-Michel Hautbois" <jeanmichel.hautbois@...asonboard.com>, "Dmitry
 Perchanov" <dmitry.perchanov@...el.com>, "Tomi Valkeinen"
 <tomi.valkeinen@...asonboard.com>, <devicetree@...r.kernel.org>,
 <linux-arm-kernel@...ts.infradead.org>, <linux-staging@...ts.linux.dev>,
 <kernel@...labora.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/6] media: v4l2: Add NV15 and NV20 pixel formats

Hi Detlev,

On Tue Mar 25, 2025 at 10:22 PM CET, Detlev Casanova wrote:
> From: Jonas Karlman <jonas@...boo.se>
>
> Add NV15 and NV20 pixel formats used by the Rockchip Video Decoder for
> 10-bit buffers.
>
> NV15 and NV20 is 10-bit 4:2:0/4:2:2 semi-planar YUV formats similar to
> NV12 and NV16, using 10-bit components with no padding between each
> component. Instead, a group of 4 luminance/chrominance samples are
> stored over 5 bytes in little endian order:
>
> YYYY = UVUV = 4 * 10 bits = 40 bits = 5 bytes
>
> The '15' and '20' suffix refers to the optimum effective bits per pixel
> which is achieved when the total number of luminance samples is a
> multiple of 8 for NV15 and 4 for NV20.
>
> Signed-off-by: Jonas Karlman <jonas@...boo.se>
> Tested-by: Nicolas Dufresne <nicolas.dufresne@...labora.com>
> Tested-by: Christopher Obbard <chris.obbard@...labora.com>
> ---
>  .../media/v4l/pixfmt-yuv-planar.rst           | 128 ++++++++++++++++++
>  drivers/media/v4l2-core/v4l2-common.c         |   2 +
>  drivers/media/v4l2-core/v4l2-ioctl.c          |   2 +
>  include/uapi/linux/videodev2.h                |   2 +
>  4 files changed, 134 insertions(+)
>
> diff --git a/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst b/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst
> index b788f69338554..22cad8c9726bf 100644
> --- a/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst
> +++ b/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst
> @@ -79,6 +79,13 @@ All components are stored with the same number of bits per component.
>        - Cr, Cb
>        - Yes
>        - Linear
> +    * - V4L2_PIX_FMT_NV15
> +      - 'NV15'
> +      - 10
> +      - 4:2:0
> +      - Cb, Cr
> +      - Yes
> +      - Linear

In your cover letter you mentioned:
Imported improvements from [1]
[1]: https://lore.kernel.org/linux-media/20250225-rkvdec_h264_high10_and_422_support-v7-2-7992a68a4910@collabora.com/

The changelog of "media: rkvdec: Add H.264 High 10 and 4:2:2 profile
support" v7 had this:
- Move V4L2_PIX_FMT_NV15/V4L2_PIX_FMT_NV20 documentation as suggested

Following a comment on v6 of that series.

But it seems these blocks are now placed at the location as it was in
the v6 series, thus NOT importing its improvements?

>      * - V4L2_PIX_FMT_NV12M
>        - 'NM12'
>        - 8
> @@ -172,6 +179,13 @@ All components are stored with the same number of bits per component.
>        - Cr, Cb
>        - Yes
>        - Linear
> +    * - V4L2_PIX_FMT_NV20
> +      - 'NV20'
> +      - 10
> +      - 4:2:2
> +      - Cb, Cr
> +      - Yes
> +      - Linear
>      * - V4L2_PIX_FMT_NV16M
>        - 'NM16'
>        - 8

The same thing seemed to have happened here?

Cheers,
  Diederik

> @@ -302,6 +316,57 @@ of the luma plane.
>        - Cr\ :sub:`11`
>  
>  
> +.. _V4L2-PIX-FMT-NV15:
> +
> +NV15
> +----
> +
> +Semi-planar 10-bit YUV 4:2:0 format similar to NV12, using 10-bit components
> +with no padding between each component. A group of 4 components are stored over
> +5 bytes in little endian order.
> +
> +.. flat-table:: Sample 4x4 NV15 Image (1 byte per cell)
> +    :header-rows:  0
> +    :stub-columns: 0

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)