linux-kernel - Re: [PATCH v4 6/6] arm64: dts: rockchip: Add rkvdec2 Video Decoder on rk3588(s)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9432379.CDJkKcVGEf@diego>
Date: Tue, 08 Apr 2025 15:16:05 +0200
From: Heiko Stübner <heiko@...ech.de>
To: linux-kernel@...r.kernel.org,
 Detlev Casanova <detlev.casanova@...labora.com>
Cc: Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Hans Verkuil <hverkuil@...all.nl>,
 Nicolas Dufresne <nicolas.dufresne@...labora.com>,
 Andrzej Pietrasiewicz <andrzej.p@...labora.com>,
 Jonas Karlman <jonas@...boo.se>,
 Sebastian Reichel <sebastian.reichel@...labora.com>,
 Niklas Cassel <cassel@...nel.org>, Alexey Charkov <alchark@...il.com>,
 Dragan Simic <dsimic@...jaro.org>, Jianfeng Liu <liujianfeng1994@...il.com>,
 Detlev Casanova <detlev.casanova@...labora.com>,
 Jacopo Mondi <jacopo.mondi@...asonboard.com>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Kieran Bingham <kieran.bingham@...asonboard.com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Umang Jain <umang.jain@...asonboard.com>,
 Naushir Patuck <naush@...pberrypi.com>,
 Jean-Michel Hautbois <jeanmichel.hautbois@...asonboard.com>,
 Dmitry Perchanov <dmitry.perchanov@...el.com>,
 Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
 linux-media@...r.kernel.org, linux-rockchip@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-staging@...ts.linux.dev, kernel@...labora.com
Subject:
 Re: [PATCH v4 6/6] arm64: dts: rockchip: Add rkvdec2 Video Decoder on
 rk3588(s)

Hi Detlev,

Am Dienstag, 25. März 2025, 22:22:22 Mitteleuropäische Sommerzeit schrieb Detlev Casanova:
> Add the rkvdec2 Video Decoder to the RK3588s devicetree.
> 
> Signed-off-by: Detlev Casanova <detlev.casanova@...labora.com>
> ---

> +	vdec1_mmu: iommu@...40700 {
> +		compatible = "rockchip,rk3588-iommu", "rockchip,rk3568-iommu";
> +		reg = <0x0 0xfdc40700 0x0 0x40>, <0x0 0xfdc40740 0x0 0x40>;
> +		interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH 0>;
> +		clocks = <&cru ACLK_RKVDEC0>, <&cru HCLK_RKVDEC0>;
> +		clock-names = "aclk", "iface";
> +		power-domains = <&power RK3588_PD_RKVDEC0>;
> +		#iommu-cells = <0>;
> +	};

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
index 24ecbff06cd27..8bde8e257eac9 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
@@ -1395,7 +1395,7 @@ vdec1_mmu: iommu@...40700 {
                interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH 0>;
                clocks = <&cru ACLK_RKVDEC0>, <&cru HCLK_RKVDEC0>;
                clock-names = "aclk", "iface";
-               power-domains = <&power RK3588_PD_RKVDEC0>;
+               power-domains = <&power RK3588_PD_RKVDEC1>;
                #iommu-cells = <0>;
        };

Needs to use the correct power-domain, otherwise ends in SErrors on 6.15-rc1


Heiko