linux-kernel - Re: [PATCH v2] drm/prime: fix drm_prime_gem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8a4772c0-7789-4697-94c7-5cb364fc4ee6@amd.com>
Date: Fri, 28 Mar 2025 13:46:23 +0100
From: Christian König <christian.koenig@....com>
To: Danilo Krummrich <dakr@...nel.org>,
 Chris Bainbridge <chris.bainbridge@...il.com>
Cc: nouveau@...ts.freedesktop.org, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch,
 lyude@...hat.com, sumit.semwal@...aro.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drm/prime: fix drm_prime_gem_destroy comment

Am 28.03.25 um 12:01 schrieb Danilo Krummrich:
> On Wed, Mar 26, 2025 at 01:10:58PM +0000, Chris Bainbridge wrote:
>> Edit the comments on correct usage of drm_prime_gem_destroy to note
>> that, if using TTM, drm_prime_gem_destroy must be called in the
>> ttm_buffer_object.destroy hook, to avoid the dma_buf being freed leaving
>> a dangling pointer which will be later dereferenced by
>> ttm_bo_delayed_delete.
>>
>> Signed-off-by: Chris Bainbridge <chris.bainbridge@...il.com>
>> Suggested-by: Christian König <christian.koenig@....com>
> Can you please send new version of patches as a new mail thread (not in reply to
> previous versions) please?
>
> Otherwise,
>
> 	Reviewed-by: Danilo Krummrich <dakr@...nel.org>
>
> @Christian, I assume you will pick this one up?

Sure, I can take care of that.

Regards,
Christian.