linux-kernel - Re: [PATCH 1/2] arm64: dts: qcom: sa8775p: add QCrypto node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <gkjdjzmhtsr4la5ami4qnsqgrd3zzdvu46eyaxpwh2brfsqm6m@wwkuxljbfwa4>
Date: Fri, 28 Mar 2025 14:48:21 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Yuvaraj Ranganathan <quic_yrangana@...cinc.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: sa8775p: add QCrypto node

On Fri, Mar 28, 2025 at 11:34:58AM +0530, Yuvaraj Ranganathan wrote:
> 
> 
> On 3/27/2025 12:38 PM, Krzysztof Kozlowski wrote:
> > On 26/03/2025 18:40, Yuvaraj Ranganathan wrote:
> >> On 3/25/2025 1:00 PM, Krzysztof Kozlowski wrote:
> >>> On 27/02/2025 19:08, Yuvaraj Ranganathan wrote:
> >>>> The initial QCE node change is reverted by the following patch 
> >>>> https://lore.kernel.org/all/20250128115333.95021-1-krzysztof.kozlowski@linaro.org/
> >>>
> >>> Use commit SHA syntax (see submitting patches, checkpatch).
> >>>
> >>>> because of the build warning,
> >>>>
> >>>>   sa8775p-ride.dtb: crypto@...a000: compatible: 'oneOf' conditional failed, one must be fixed:
> >>>>     ...
> >>>>     'qcom,sa8775p-qce' is not one of ['qcom,ipq4019-qce', 'qcom,sm8150-qce']
> >>>
> >>> Not relevant warning.
> >>>
> >>>
> >>>
> >>> Best regards,
> >>> Krzysztof
> >>
> >> Are you saying this is not the warning seen at merging?
> > Tell me how it is relevant? Tell me how can I reproduce it.
> > 
> > Best regards,
> > Krzysztof
> 
> Below commands will show the above warnings without the fix,
> make clean && make qcom/qcs9100-ride.dtb CHECK_DTBS=1
> make clean && make qcom/qcs8300-ride.dtb CHECK_DTBS=1

You are probably running those commands on a tree where the patch was
not reverted. That's useless. Please update your patches to stop
mentioning the (outdated) warning and just describe your changes (i.e.
adding the QCE nodes, you are not fixing any warnings with your change).

-- 
With best wishes
Dmitry