linux-kernel - Re: [PATCH] mm: migrate: restore the nmask after successfully allocating on the target node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z-anohhuNGiQ7kib@localhost.localdomain>
Date: Fri, 28 Mar 2025 14:44:02 +0100
From: Oscar Salvador <osalvador@...e.de>
To: wangchuanguo <wangchuanguo@...pur.com>
Cc: akpm@...ux-foundation.org, mhiramat@...nel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: migrate: restore the nmask after successfully
 allocating on the  target node

On Wed, Mar 26, 2025 at 11:12:18AM +0800, wangchuanguo wrote:
> If memory is successfully allocated on the target node and the
> function directly returns without value restore for nmask,
> non-first migration operations in migrate_pages() by again label
> may ignore the nmask settings, thereby allowing new memory
> allocations for migration on any node.
> 
> Signed-off-by: wangchuanguo <wangchuanguo@...pur.com>

Unless I am missing something this looks reasonable, but I whonder why nobody
noticed it before.
It is a path that should be pretty exercised.


-- 
Oscar Salvador
SUSE Labs