[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <989e695e-e6a4-4427-9041-e39ecf5b5674@acm.org>
Date: Fri, 28 Mar 2025 07:02:20 -0700
From: Bart Van Assche <bvanassche@....org>
To: "Bao D. Nguyen" <quic_nguyenb@...cinc.com>,
Arthur Simchaev <Arthur.Simchaev@...disk.com>,
"quic_cang@...cinc.com" <quic_cang@...cinc.com>,
"quic_nitirawa@...cinc.com" <quic_nitirawa@...cinc.com>,
"avri.altman@....com" <avri.altman@....com>,
"peter.wang@...iatek.com" <peter.wang@...iatek.com>,
"manivannan.sadhasivam@...aro.org" <manivannan.sadhasivam@...aro.org>,
"minwoo.im@...sung.com" <minwoo.im@...sung.com>,
"adrian.hunter@...el.com" <adrian.hunter@...el.com>,
"martin.petersen@...cle.com" <martin.petersen@...cle.com>
Cc: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
Alim Akhtar <alim.akhtar@...sung.com>,
"James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
Bean Huo <beanhuo@...ron.com>, Keoseong Park <keosung.park@...sung.com>,
Ziqi Chen <quic_ziqichen@...cinc.com>, Al Viro <viro@...iv.linux.org.uk>,
Gwendal Grignou <gwendal@...omium.org>, Eric Biggers <ebiggers@...gle.com>,
open list <linux-kernel@...r.kernel.org>,
"moderated list:ARM/Mediatek SoC support:Keyword:mediatek"
<linux-arm-kernel@...ts.infradead.org>,
"moderated list:ARM/Mediatek SoC support:Keyword:mediatek"
<linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH v4 1/1] scsi: ufs: core: add device level exception
support
On 3/27/25 5:45 PM, Bao D. Nguyen wrote:
> Thanks Bart. How about we change the current utp_upiu_query_v4_0 to
>
> struct utp_upiu_query_v4_0 {
> __u8 opcode;
> __u8 idn;
> __u8 index;
> __u8 selector;
> __u8 cmd_specifics[8];
> /* private: */
> __be32 reserved;
> };
>
> Depending on the opcode/transaction, the cmd_specifics[] can be type
> casted to access the LENGTH, FLAG_VALUE, VALUE[0:63] fields of the QUERY
> UPIU. The __u8 array[8] would also prevent the compiler padding to the
> data.
Are there any user space applications that use the osf3/4/5/6/7 member
names? Has it been considered to preserve these by introducing a union?
Thanks,
Bart.
Powered by blists - more mailing lists