linux-kernel - Re: [PATCH v4 1/1] scsi: ufs: core: add device level exception support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yzy7oad77h744vf2bdylkm4fronemjwvrmlstnj6x5lzjxg672@zya6toqv4aeg>
Date: Wed, 2 Apr 2025 13:19:23 +0530
From: 
	"manivannan.sadhasivam@...aro.org" <manivannan.sadhasivam@...aro.org>
To: Bart Van Assche <bvanassche@....org>
Cc: "Bao D. Nguyen" <quic_nguyenb@...cinc.com>, 
	Arthur Simchaev <Arthur.Simchaev@...disk.com>, "quic_cang@...cinc.com" <quic_cang@...cinc.com>, 
	"quic_nitirawa@...cinc.com" <quic_nitirawa@...cinc.com>, "avri.altman@....com" <avri.altman@....com>, 
	"peter.wang@...iatek.com" <peter.wang@...iatek.com>, "minwoo.im@...sung.com" <minwoo.im@...sung.com>, 
	"adrian.hunter@...el.com" <adrian.hunter@...el.com>, "martin.petersen@...cle.com" <martin.petersen@...cle.com>, 
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>, Alim Akhtar <alim.akhtar@...sung.com>, 
	"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>, Matthias Brugger <matthias.bgg@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Bean Huo <beanhuo@...ron.com>, 
	Keoseong Park <keosung.park@...sung.com>, Ziqi Chen <quic_ziqichen@...cinc.com>, 
	Al Viro <viro@...iv.linux.org.uk>, Gwendal Grignou <gwendal@...omium.org>, 
	Eric Biggers <ebiggers@...gle.com>, open list <linux-kernel@...r.kernel.org>, 
	"moderated list:ARM/Mediatek SoC support:Keyword:mediatek" <linux-arm-kernel@...ts.infradead.org>, 
	"moderated list:ARM/Mediatek SoC support:Keyword:mediatek" <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH v4 1/1] scsi: ufs: core: add device level exception
 support

On Fri, Mar 28, 2025 at 07:02:20AM -0700, Bart Van Assche wrote:
> On 3/27/25 5:45 PM, Bao D. Nguyen wrote:
> > Thanks Bart. How about we change the current utp_upiu_query_v4_0 to
> > 
> > struct utp_upiu_query_v4_0 {
> >          __u8 opcode;
> >          __u8 idn;
> >          __u8 index;
> >          __u8 selector;
> >          __u8 cmd_specifics[8];
> >          /* private: */
> >          __be32 reserved;
> > };
> > 
> > Depending on the opcode/transaction, the cmd_specifics[] can be type
> > casted to access the LENGTH, FLAG_VALUE, VALUE[0:63] fields of the QUERY
> > UPIU. The __u8 array[8] would also prevent the compiler padding to the
> > data.
> 
> Are there any user space applications that use the osf3/4/5/6/7 member
> names?

Yeah, we should be cautious in changing the uAPI header as it can break the
userspace applications. Annotating the members that need packed attribute seems
like the way forward to me.

Though, I'd like to understand which architecture has the alignment constraint
in this structure. Only if an architecture requires 8 byte alignment for __be32
would be a problem. That too only for osf7 and reserved. But I'm not aware of
such architectures in use.

- Mani

-- 
மணிவண்ணன் சதாசிவம்