linux-kernel - RE: [PATCH] ASoC: SOF: Intel: hda-sdw-bpt: select CONFIG_SND_SOF_SOF_HDA_SDW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ2PR11MB8424B5677C548803F2F2A513FFA02@SJ2PR11MB8424.namprd11.prod.outlook.com>
Date: Fri, 28 Mar 2025 14:15:36 +0000
From: "Liao, Bard" <bard.liao@...el.com>
To: Arnd Bergmann <arnd@...nel.org>, Liam Girdwood <lgirdwood@...il.com>,
	Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>, Bard Liao
	<yung-chuan.liao@...ux.intel.com>, Ranjani Sridharan
	<ranjani.sridharan@...ux.intel.com>, Daniel Baluta <daniel.baluta@....com>,
	Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, "Takashi
 Iwai" <tiwai@...e.com>, Vinod Koul <vkoul@...nel.org>
CC: Arnd Bergmann <arnd@...db.de>, Kai Vehmanen
	<kai.vehmanen@...ux.intel.com>, Pierre-Louis Bossart
	<pierre-louis.bossart@...ux.dev>, "sound-open-firmware@...a-project.org"
	<sound-open-firmware@...a-project.org>, "linux-sound@...r.kernel.org"
	<linux-sound@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ASoC: SOF: Intel: hda-sdw-bpt: select
 CONFIG_SND_SOF_SOF_HDA_SDW_BPT



> -----Original Message-----
> From: Arnd Bergmann <arnd@...nel.org>
> Sent: Friday, March 28, 2025 9:25 PM
> To: Liam Girdwood <lgirdwood@...il.com>; Peter Ujfalusi
> <peter.ujfalusi@...ux.intel.com>; Bard Liao <yung-chuan.liao@...ux.intel.com>;
> Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>; Daniel Baluta
> <daniel.baluta@....com>; Mark Brown <broonie@...nel.org>; Jaroslav Kysela
> <perex@...ex.cz>; Takashi Iwai <tiwai@...e.com>; Vinod Koul
> <vkoul@...nel.org>
> Cc: Arnd Bergmann <arnd@...db.de>; Kai Vehmanen
> <kai.vehmanen@...ux.intel.com>; Pierre-Louis Bossart <pierre-
> louis.bossart@...ux.dev>; sound-open-firmware@...a-project.org; linux-
> sound@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] ASoC: SOF: Intel: hda-sdw-bpt: select
> CONFIG_SND_SOF_SOF_HDA_SDW_BPT
> 
> From: Arnd Bergmann <arnd@...db.de>
> 
> The newly added driver fails to link without this:
> 
> ERROR: modpost: "snd_hdac_ext_stream_start" [sound/soc/sof/intel/snd-sof-
> intel-hda-sdw-bpt.ko] undefined!
> ERROR: modpost: "snd_hdac_ext_stream_clear" [sound/soc/sof/intel/snd-sof-
> intel-hda-sdw-bpt.ko] undefined!
> ERROR: modpost: "snd_hdac_ext_stream_setup" [sound/soc/sof/intel/snd-sof-
> intel-hda-sdw-bpt.ko] undefined!
> ERROR: modpost: "snd_hdac_ext_bus_link_set_stream_id"
> [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!
> ERROR: modpost: "snd_hdac_ext_stream_reset" [sound/soc/sof/intel/snd-sof-
> intel-hda-sdw-bpt.ko] undefined!
> ERROR: modpost: "snd_hdac_ext_bus_link_clear_stream_id"
> [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!
> 
> Fixes: 5d5cb86fb46e ("ASoC: SOF: Intel: hda-sdw-bpt: add helpers for SoundWire
> BPT DMA")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

I have the same patch which is pending review/apply.
https://patchwork.kernel.org/project/alsa-devel/patch/20250321023032.7420-2-yung-chuan.liao@linux.intel.com/
I am fine if we go with this patch.
Acked-by: Bard Liao <yung-chuan.liao@...ux.intel.com>


> ---
>  sound/soc/sof/intel/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/sof/intel/Kconfig b/sound/soc/sof/intel/Kconfig
> index 41cb33fe98fb..7e92aa2f7e39 100644
> --- a/sound/soc/sof/intel/Kconfig
> +++ b/sound/soc/sof/intel/Kconfig
> @@ -351,6 +351,7 @@ endif ## SND_SOC_SOF_HDA_GENERIC
> 
>  config SND_SOF_SOF_HDA_SDW_BPT
>  	tristate
> +	select SND_HDA_EXT_CORE
>  	help
>  	  This option is not user-selectable but automagically handled by
>  	  'select' statements at a higher level.
> --
> 2.39.5