linux-kernel - Re: [PATCH] ASoC: SOF: Intel: hda-sdw-bpt: select CONFIG_SND_SOF_SOF_HDA_SDW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z+o9D7FhTyUp2Y9o@vaman>
Date: Mon, 31 Mar 2025 12:28:23 +0530
From: Vinod Koul <vkoul@...nel.org>
To: "Liao, Bard" <bard.liao@...el.com>
Cc: Arnd Bergmann <arnd@...nel.org>, Liam Girdwood <lgirdwood@...il.com>,
	Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
	Bard Liao <yung-chuan.liao@...ux.intel.com>,
	Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
	Daniel Baluta <daniel.baluta@....com>,
	Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, Arnd Bergmann <arnd@...db.de>,
	Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>,
	"sound-open-firmware@...a-project.org" <sound-open-firmware@...a-project.org>,
	"linux-sound@...r.kernel.org" <linux-sound@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: SOF: Intel: hda-sdw-bpt: select
 CONFIG_SND_SOF_SOF_HDA_SDW_BPT

On 28-03-25, 14:15, Liao, Bard wrote:
> 
> 
> > -----Original Message-----
> > From: Arnd Bergmann <arnd@...nel.org>
> > Sent: Friday, March 28, 2025 9:25 PM
> > To: Liam Girdwood <lgirdwood@...il.com>; Peter Ujfalusi
> > <peter.ujfalusi@...ux.intel.com>; Bard Liao <yung-chuan.liao@...ux.intel.com>;
> > Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>; Daniel Baluta
> > <daniel.baluta@....com>; Mark Brown <broonie@...nel.org>; Jaroslav Kysela
> > <perex@...ex.cz>; Takashi Iwai <tiwai@...e.com>; Vinod Koul
> > <vkoul@...nel.org>
> > Cc: Arnd Bergmann <arnd@...db.de>; Kai Vehmanen
> > <kai.vehmanen@...ux.intel.com>; Pierre-Louis Bossart <pierre-
> > louis.bossart@...ux.dev>; sound-open-firmware@...a-project.org; linux-
> > sound@...r.kernel.org; linux-kernel@...r.kernel.org
> > Subject: [PATCH] ASoC: SOF: Intel: hda-sdw-bpt: select
> > CONFIG_SND_SOF_SOF_HDA_SDW_BPT
> > 
> > From: Arnd Bergmann <arnd@...db.de>
> > 
> > The newly added driver fails to link without this:
> > 
> > ERROR: modpost: "snd_hdac_ext_stream_start" [sound/soc/sof/intel/snd-sof-
> > intel-hda-sdw-bpt.ko] undefined!
> > ERROR: modpost: "snd_hdac_ext_stream_clear" [sound/soc/sof/intel/snd-sof-
> > intel-hda-sdw-bpt.ko] undefined!
> > ERROR: modpost: "snd_hdac_ext_stream_setup" [sound/soc/sof/intel/snd-sof-
> > intel-hda-sdw-bpt.ko] undefined!
> > ERROR: modpost: "snd_hdac_ext_bus_link_set_stream_id"
> > [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!
> > ERROR: modpost: "snd_hdac_ext_stream_reset" [sound/soc/sof/intel/snd-sof-
> > intel-hda-sdw-bpt.ko] undefined!
> > ERROR: modpost: "snd_hdac_ext_bus_link_clear_stream_id"
> > [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!
> > 
> > Fixes: 5d5cb86fb46e ("ASoC: SOF: Intel: hda-sdw-bpt: add helpers for SoundWire
> > BPT DMA")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> I have the same patch which is pending review/apply.
> https://patchwork.kernel.org/project/alsa-devel/patch/20250321023032.7420-2-yung-chuan.liao@linux.intel.com/
> I am fine if we go with this patch.
> Acked-by: Bard Liao <yung-chuan.liao@...ux.intel.com>

I have picked yours as that came first, thanks

-- 
~Vinod