linux-kernel - Re: [PATCH v2 07/10] arm64: dts: qcom: sa8775p-ride: add anx7625 DSI to DP bridge nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4aebd1f6-5098-4548-adae-843db8f45aa5@kernel.org>
Date: Fri, 28 Mar 2025 15:28:20 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ayushi Makhija <quic_amakhija@...cinc.com>
Cc: linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 freedreno@...ts.freedesktop.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, robdclark@...il.com,
 dmitry.baryshkov@...aro.org, sean@...rly.run, marijn.suijten@...ainline.org,
 andersson@...nel.org, robh@...nel.org, robh+dt@...nel.org,
 krzk+dt@...nel.org, konradybcio@...nel.org, conor+dt@...nel.org,
 andrzej.hajda@...el.com, neil.armstrong@...aro.org, rfoss@...nel.org,
 Laurent.pinchart@...asonboard.com, jonas@...boo.se,
 jernej.skrabec@...il.com, quic_abhinavk@...cinc.com,
 quic_rajeevny@...cinc.com, quic_vproddut@...cinc.com,
 quic_jesszhan@...cinc.com
Subject: Re: [PATCH v2 07/10] arm64: dts: qcom: sa8775p-ride: add anx7625 DSI
 to DP bridge nodes

On 13/03/2025 13:10, Ayushi Makhija wrote:

...

> 
>> +
>> +			anx_bridge_1: anx7625@58 {
> 
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> 
> In this I have changed the node name as anx_bridge1 : anx7625@58.

Except that it is difficult to understand what is what, let's recap.

Original code was:
	anx_bridge_1: anx7625@58 {

You said you changed it to:

	anx_bridge1 : anx7625@58.

and now I give my offer: I offer to buy a beer (or tee/coffee/juice) to
anyone who will spot the difference(s) between these two node names,
IOW, tell me what changed here.

Best regards,
Krzysztof