linux-kernel - Re: [PATCH v2 2/3] i3c: master: Add Qualcomm I3C controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <172b9848-0af6-44fc-83c2-8d2b94b74d51@quicinc.com>
Date: Fri, 28 Mar 2025 19:59:44 +0530
From: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>
To: Markus Elfring <Markus.Elfring@....de>, <linux-i3c@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>
CC: LKML <linux-kernel@...r.kernel.org>,
        Alexandre Belloni
	<alexandre.belloni@...tlin.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Jarkko Nikula
	<jarkko.nikula@...ux.intel.com>,
        Konrad Dybcio <konradybcio@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v2 2/3] i3c: master: Add Qualcomm I3C controller driver

Hi Markus, Thanks for review !

On 3/28/2025 6:58 PM, Markus Elfring wrote:
> …
>> +++ b/drivers/i3c/master/qcom-i3c-master.c
>> @@ -0,0 +1,1107 @@
> …
>> +/* M_CMD OP codes for I2C/I3C */
>> +#define I3C_READ_IBI_HW          0
>> +#define I2C_WRITE                1
>> +#define I2C_READ                 2
> …
> 
> Can an enumeration become helpful here?
> 
No, these are hardware program defined op-codes not created for any 
software purpose. so Macro define looks fine to me.
> Regards,
> Markus