linux-kernel - Re: [PATCH v2 2/3] i3c: master: Add Qualcomm I3C controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0bb768d-ee4e-46c1-b8cc-5d1c3627063e@kernel.org>
Date: Fri, 28 Mar 2025 15:35:32 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>,
 alexandre.belloni@...tlin.com, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, jarkko.nikula@...ux.intel.com,
 linux-i3c@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Trilok Soni <quic_tsoni@...cinc.com>
Cc: andersson@...nel.org, konradybcio@...nel.org
Subject: Re: [PATCH v2 2/3] i3c: master: Add Qualcomm I3C controller driver

On 28/03/2025 15:28, Mukesh Kumar Savaliya wrote:
> Thanks Krzysztof for correcting !
> 
> On 3/26/2025 7:58 PM, Krzysztof Kozlowski wrote:
>> On 26/03/2025 15:16, Mukesh Kumar Savaliya wrote:
>>> +
>>> +static int i3c_geni_resources_init(struct geni_i3c_dev *gi3c, struct platform_device *pdev)
>>> +{
>>> +	int ret;
>>> +
>>> +	gi3c->se.base = devm_platform_ioremap_resource(pdev, 0);
>>> +	if (IS_ERR(gi3c->se.base))
>>> +		return PTR_ERR(gi3c->se.base);
>>> +
>>> +	gi3c->se.clk = devm_clk_get(&pdev->dev, "se-clk");
>>
>> Never tested.
>>
> sorry, i ran and i got below error now:

Please do the tests *before* you post changes You do not need community
reviewer to tell you to do static/compile time checks on your code.

> i3c@...000: Unevaluated properties are not allowed ('clock-names', 
> 'interrupts' were unexpected).
> 
> so i have made below change and ran dt_binding_check + dtbs_check, i 
> could fix the issue. Let me have this review internally specific to 
> dt-binding and will post next patch after internal review. So i can 
> avoid such misses.
> 
> yaml :
> +  clock-names:
> +    const: se
> +
> -  - interrupts-extended
> +  - interrupts
> 
> example:
> clock-names = "se";

No, drop clock names entirely, not really useful for one entry using
block's name. Just get the first clock, like most of the drivers.
> 


Best regards,
Krzysztof