linux-kernel - Re: [PATCH v2 2/3] i3c: master: Add Qualcomm I3C controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4161e6de-b16f-4371-be41-cc12adb3e9b8@quicinc.com>
Date: Fri, 28 Mar 2025 19:59:33 +0530
From: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>
To: Markus Elfring <Markus.Elfring@....de>, <linux-i3c@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>
CC: LKML <linux-kernel@...r.kernel.org>,
        Alexandre Belloni
	<alexandre.belloni@...tlin.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Jarkko Nikula
	<jarkko.nikula@...ux.intel.com>,
        Konrad Dybcio <konradybcio@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v2 2/3] i3c: master: Add Qualcomm I3C controller driver

Thanks Markus for review and suggestion !

On 3/28/2025 6:49 PM, Markus Elfring wrote:
> …
>> +++ b/drivers/i3c/master/qcom-i3c-master.c
>> @@ -0,0 +1,1107 @@
> …
>> +static void geni_i3c_abort_xfer(struct geni_i3c_dev *gi3c)
>> +{
> …
>> +	spin_lock_irqsave(&gi3c->irq_lock, flags);
>> +	geni_i3c_handle_err(gi3c, GENI_TIMEOUT);
>> +	geni_se_abort_m_cmd(&gi3c->se);
>> +	spin_unlock_irqrestore(&gi3c->irq_lock, flags);
> …
> 
> Under which circumstances would you become interested to apply a statement
> like “guard(spinlock_irqsave)(&gi3c->irq_lock);”?
Didn't get, hence a question.  Do you suggest to use DEFINE_LOCK_GUARD_1 
instead of existing method ?
> https://elixir.bootlin.com/linux/v6.14-rc6/source/include/linux/spinlock.h#L572
> 
> Regards,
> Markus
>