linux-kernel - Re: [PATCH 1/5] scsi: hisi_sas: Add host_tagset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f53505e6-9bfa-4553-91cc-497512a6977f@oracle.com>
Date: Sat, 29 Mar 2025 08:50:57 +0000
From: John Garry <john.g.garry@...cle.com>
To: Yihang Li <liyihang9@...wei.com>, martin.petersen@...cle.com,
        James.Bottomley@...senPartnership.com
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        linuxarm@...wei.com, liuyonglong@...wei.com, prime.zeng@...ilicon.com,
        "linux-ide@"@vger.kernel.org
Subject: Re: [PATCH 1/5] scsi: hisi_sas: Add host_tagset_enable module param
 for v3 hw

On 29/03/2025 07:32, Yihang Li wrote:

+

> From: Xingui Yang<yangxingui@...wei.com>
> 
> After driver exposes all HW queues and application submits IO to multiple
> queues in parallel, if NCQ and non-NCQ commands are mixed to sata disk,
> ata_qc_defer() causes non-NCQ commands to be requeued and possibly repeated
> forever.

I don't think that it is a good idea to mask out bugs with module 
parameters.

Was this the same libata/libsas issue reported some time ago?

> Add host_tagset_enable module parameter to expose multiple queues
> for v3 hw.
> 
> Signed-off-by: Xingui Yang<yangxingui@...wei.com>
> Signed-off-by: Yihang Li<liyihang9@...wei.com>