[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAAhV-H5Yc8d4qSN0Fwe=wShXHzJrdJ0KX87kV0_0ToQiHBEECQ@mail.gmail.com>
Date: Sat, 29 Mar 2025 16:45:49 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Xi Ruoyao <xry111@...111.site>, WANG Rui <wangrui@...ngson.cn>,
Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
Björn Roy Baron <bjorn3_gh@...tonmail.com>,
Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>,
Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
Danilo Krummrich <dakr@...nel.org>, rust-for-linux@...r.kernel.org,
linux-kernel@...r.kernel.org, loongarch@...ts.linux.dev,
loongson-kernel@...ts.loongnix.cn, stable@...r.kernel.org
Subject: Re: [PATCH] rust: Fix enabling Rust and building with GCC for LoongArch
Hi, Miguel,
On Sat, Mar 29, 2025 at 12:15 AM Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
>
> On Tue, Mar 4, 2025 at 10:12 AM Huacai Chen <chenhuacai@...nel.org> wrote:
> >
> > Don't rely on default behavior, things may change in future.
> > Acked-by: Huacai Chen <chenhuacai@...ngson.cn>
>
> I was pinged about this one -- are you picking this one through your tree?
OK, I wll pick it to the loongarch tree, thanks.
Huacai
>
> I didn't test it, but the change seems safe to me for other
> architectures that we have at the moment, since they don't seem to set
> any of those three from a quick look, so:
>
> Acked-by: Miguel Ojeda <ojeda@...nel.org>
>
> In any case, the usual question for these "skipped flags" is whether
> they could affect the output of `bindgen`, i.e. could they modify
> layouts somehow?
>
> Also, it would be nice to mention a bit more what was the build error
> and the GCC version in the commit message.
>
> Finally, regarding the Cc: stable, I guess that means 6.12+ since it
> is the first LTS with loongarch64, right?
>
> Thanks!
>
> Cheers,
> Miguel
Powered by blists - more mailing lists