linux-kernel - Re: [BUG -next] ./usr/include/cxl/features.h:11:10: fatal error: uuid/uuid.h: No such file or directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67e73d89dc6c4_201f029467@dwillia2-xfh.jf.intel.com.notmuch>
Date: Fri, 28 Mar 2025 17:23:37 -0700
From: Dan Williams <dan.j.williams@...el.com>
To: "Paul E. McKenney" <paulmck@...nel.org>, Dan Williams
	<dan.j.williams@...el.com>
CC: Dave Jiang <dave.jiang@...el.com>, <linux-cxl@...r.kernel.org>,
	<dave@...olabs.net>, <jonathan.cameron@...wei.com>,
	<alison.schofield@...el.com>, <vishal.l.verma@...el.com>,
	<ira.weiny@...el.com>, <gourry@...rry.net>, <linux-kernel@...r.kernel.org>,
	<linux-next@...r.kernel.org>, <sfr@...b.auug.org.au>
Subject: Re: [BUG -next] ./usr/include/cxl/features.h:11:10: fatal error:
 uuid/uuid.h: No such file or directory

Paul E. McKenney wrote:
> On Fri, Mar 28, 2025 at 04:26:21PM -0700, Dan Williams wrote:
> > Paul E. McKenney wrote:
> > [..]
> > > > > Making the above change got me this:
> > > > > 
> > > > > usr/include/cxl/features.h:59:9: error: unknown type name ‘uuid_t’
> > > > I wasn't able to hit that with allmodconfig on x86 with a Fedora 41 build setup. What is the specific command lines you are using?
> > > 
> > > make clean
> > > make allmodconfig
> > > make -j$N
> > > 
> > > Though encapsulated as follows:
> > > 
> > > tools/testing/selftests/rcutorture/bin/torture.sh --do-none --do-allmodconfig
> > 
> > The problem is that uuid_t is not defined for uapi headers to reuse.
> > Perhaps checkpatch should be checking for uuid_t in uapi headers going
> > forward.
> 
> And for whatever it is worth, "git bisect" converged here:
> 
> 9b8e73cdb141 cxl: Move cxl feature command structs to user header

That makes sense because that was the point at which the usage of uuid_t
in those data structures became invalid.

I am going to have a firm talking to whomever added their Reviewed-by to
that... cue Michael Jackson's "I'm looking at the man in the mirror".

> > For now the following builds for me, but it is a quite a mess to undo
> > the assumption that that the hardware object definitions can not use
> > uuid_t:
> 
> Even better, this builds fine for me:
> 
> Tested-by: Paul E. McKenney <paulmck@...nel.org>
> 
> Thank you both!

Thanks for the bisect Paul!