[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Z-c91HQmMb2ozGdh@fedora>
Date: Sat, 29 Mar 2025 08:24:52 +0800
From: Ming Lei <ming.lei@...hat.com>
To: Caleb Sander Mateos <csander@...estorage.com>
Cc: Jens Axboe <axboe@...nel.dk>, Shuah Khan <shuah@...nel.org>,
linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-kselftest@...r.kernel.org
Subject: Re: [PATCH 0/2] ublk: specify io_cmd_buf pointer type
On Fri, Mar 28, 2025 at 01:42:28PM -0600, Caleb Sander Mateos wrote:
> io_cmd_buf points to an array of ublksrv_io_desc structs but its type is
> char *. Indexing the array requires an explicit multiplication and cast.
> The compiler also can't check the pointer types.
>
> Change io_cmd_buf's type to struct ublksrv_io_desc * so it can be
> indexed directly and the compiler can type-check the code.
>
> Make the same change to the ublk selftests.
>
> Caleb Sander Mateos (2):
> ublk: specify io_cmd_buf pointer type
> selftests: ublk: specify io_cmd_buf pointer type
>
> drivers/block/ublk_drv.c | 8 ++++----
> tools/testing/selftests/ublk/kublk.c | 2 +-
> tools/testing/selftests/ublk/kublk.h | 4 ++--
> 3 files changed, 7 insertions(+), 7 deletions(-)
Reviewed-by: Ming Lei <ming.lei@...hat.com>
Thanks,
Ming
Powered by blists - more mailing lists