linux-kernel - Re: [PATCH] Fix memory leak in brcmf_get_module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a7e5afa0-6f80-4685-b901-86112fca61c5@web.de>
Date: Sun, 30 Mar 2025 13:33:13 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Abdun Nihaal <abdun.nihaal@...il.com>,
 brcm80211-dev-list.pdl@...adcom.com, brcm80211@...ts.linux.dev,
 linux-wireless@...r.kernel.org,
 Arend van Spriel <arend.vanspriel@...adcom.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Jacobe Zang
 <jacobe.zang@...ion.com>, Jeff Johnson <jeff.johnson@....qualcomm.com>,
 Kalle Valo <kvalo@...nel.org>, Ondřej Jirman <megi@....cz>,
 Sai Krishna <saikrishnag@...vell.com>,
 Sebastian Reichel <sebastian.reichel@...labora.com>,
 Toke Høiland-Jørgensen <toke@...e.dk>,
 Uwe Kleine-König <u.kleine-koenig@...libre.com>
Subject: Re: [PATCH] Fix memory leak in brcmf_get_module_param

> The memory allocated for settings is not freed when brcmf_of_probe
> fails. Fix that by freeing settings before returning in error path.

  failed?

* Would you like to append parentheses to any function names?

* See also:
  https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14#n631


Regards,
Markus