linux-kernel - Re: [PATCH] Fix memory leak in brcmf_get_module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <195e68b2ab8.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
Date: Sun, 30 Mar 2025 12:13:56 +0200
From: Arend Van Spriel <arend.vanspriel@...adcom.com>
To: Abdun Nihaal <abdun.nihaal@...il.com>
CC: <kvalo@...nel.org>, <jeff.johnson@....qualcomm.com>, <toke@...e.dk>, <jacobe.zang@...ion.com>, <u.kleine-koenig@...libre.com>, <megi@....cz>, <sebastian.reichel@...labora.com>, <saikrishnag@...vell.com>, <linux-wireless@...r.kernel.org>, <brcm80211@...ts.linux.dev>, <brcm80211-dev-list.pdl@...adcom.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Fix memory leak in brcmf_get_module_param

On March 30, 2025 12:09:04 PM Arend Van Spriel 
<arend.vanspriel@...adcom.com> wrote:

> On March 30, 2025 11:35:41 AM Abdun Nihaal <abdun.nihaal@...il.com> wrote:
>
>> The memory allocated for settings is not freed when brcmf_of_probe
>> fails. Fix that by freeing settings before returning in error path.
>>
>> Fixes: 0ff0843310b7 ("wifi: brcmfmac: Add optional lpo clock enable support")
>
> Good catch. Thanks for the fix.

The patch is fine, but a minor procedural nit that I should mention. The 
subject of patches for brcmfmac should have prefix "wifi: brcmfmac:" as 
shown in the Fixes: line. Hopefully Kalle can take care of that.

Regards,
Arend

>
> Acked-by: Arend van Spriel <arend.vanspriel@...adcom.com>
>> Signed-off-by: Abdun Nihaal <abdun.nihaal@...il.com>
>> ---
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)