linux-kernel - Re: [PATCH v2 03/13] iio: light: al3010: Remove DRV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250330182710.4ce400ae@jic23-huawei>
Date: Sun, 30 Mar 2025 18:27:10 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: David Heidelberg via B4 Relay <devnull+david.ixit.cz@...nel.org>
Cc: david@...t.cz, Lars-Peter Clausen <lars@...afoo.de>, Svyatoslav Ryhel
 <clamor95@...il.com>, Robert Eckelmann <longnoserob@...il.com>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 03/13] iio: light: al3010: Remove DRV_NAME definition

On Wed, 19 Mar 2025 21:59:42 +0100
David Heidelberg via B4 Relay <devnull+david.ixit.cz@...nel.org> wrote:

> From: David Heidelberg <david@...t.cz>
> 
> The driver name should be passed directly.
> 
> Signed-off-by: David Heidelberg <david@...t.cz>
Also things I'd generally not worry too much about in existing code.
Given they are part of a larger series though I'll take them.
Applied 3-4

> ---
>  drivers/iio/light/al3010.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/light/al3010.c b/drivers/iio/light/al3010.c
> index 4c2fd88ab32cd73f4735b0fa3014af084037c94d..7fe91049b55e57558aef69d088d168437a6819ec 100644
> --- a/drivers/iio/light/al3010.c
> +++ b/drivers/iio/light/al3010.c
> @@ -22,8 +22,6 @@
>  #include <linux/iio/iio.h>
>  #include <linux/iio/sysfs.h>
>  
> -#define AL3010_DRV_NAME "al3010"
> -
>  #define AL3010_REG_SYSTEM		0x00
>  #define AL3010_REG_DATA_LOW		0x0c
>  #define AL3010_REG_CONFIG		0x10
> @@ -184,7 +182,7 @@ static int al3010_probe(struct i2c_client *client)
>  	data->client = client;
>  
>  	indio_dev->info = &al3010_info;
> -	indio_dev->name = AL3010_DRV_NAME;
> +	indio_dev->name = "al3010";
>  	indio_dev->channels = al3010_channels;
>  	indio_dev->num_channels = ARRAY_SIZE(al3010_channels);
>  	indio_dev->modes = INDIO_DIRECT_MODE;
> @@ -224,7 +222,7 @@ MODULE_DEVICE_TABLE(of, al3010_of_match);
>  
>  static struct i2c_driver al3010_driver = {
>  	.driver = {
> -		.name = AL3010_DRV_NAME,
> +		.name = "al3010",
>  		.of_match_table = al3010_of_match,
>  		.pm = pm_sleep_ptr(&al3010_pm_ops),
>  	},
>