linux-kernel - Re: [PATCH] kunit: fixes backtrace suppression test module description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABVgOS=s-NgS1tPOOPDstuVfTmsW9H0kP8nEQmtfFiubQeyvWw@mail.gmail.com>
Date: Sun, 30 Mar 2025 13:11:59 +0800
From: David Gow <davidgow@...gle.com>
To: Alessandro Carminati <acarmina@...hat.com>
Cc: linux-kselftest@...r.kernel.org, Dan Carpenter <dan.carpenter@...aro.org>, 
	Kees Cook <keescook@...omium.org>, Daniel Diaz <daniel.diaz@...aro.org>, 
	Arthur Grillo <arthurgrillo@...eup.net>, Brendan Higgins <brendan.higgins@...ux.dev>, 
	Naresh Kamboju <naresh.kamboju@...aro.org>, Andrew Morton <akpm@...ux-foundation.org>, 
	Maxime Ripard <mripard@...nel.org>, Ville Syrjala <ville.syrjala@...ux.intel.com>, 
	Daniel Vetter <daniel@...ll.ch>, Guenter Roeck <linux@...ck-us.net>, 
	Alessandro Carminati <alessandro.carminati@...il.com>, Jani Nikula <jani.nikula@...el.com>, 
	Stephen Rothwell <sfr@...b.auug.org.au>, Jeff Johnson <jeff.johnson@....qualcomm.com>, 
	dri-devel@...ts.freedesktop.org, kunit-dev@...glegroups.com, 
	linux-kernel@...r.kernel.org, linux-next@...r.kernel.org
Subject: Re: [PATCH] kunit: fixes backtrace suppression test module description

On Sat, 29 Mar 2025 at 23:06, Alessandro Carminati <acarmina@...hat.com> wrote:
>
> Adds module description to the backtrace suppression test
>
> Fixes:  ("19f3496") kunit: add test cases for backtrace warning suppression
>
> Signed-off-by: Alessandro Carminati <acarmina@...hat.com>
> ---

The "Fixes" tag here should be immediately before the Signed-off-by
line, without a newline. Also, ideally the format should be something
like:
Fixes: d03d078df162 ("kunit: add test cases for backtrace warning suppression")

(But you'll need to make sure the commit hash matches the one which
actually lands -- I picked d03d078df162 from the current
mm-nonmm-unstable branch.)

Nevertheless, I like the content of this, so it should be either
accepted or rolled into a new version of the backtrace suppression
test.

Acked-by: David Gow <davidgow@...gle.com>

Cheers,
-- David

>  lib/kunit/backtrace-suppression-test.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/kunit/backtrace-suppression-test.c b/lib/kunit/backtrace-suppression-test.c
> index 8b4125af2481..d4c5df09bba6 100644
> --- a/lib/kunit/backtrace-suppression-test.c
> +++ b/lib/kunit/backtrace-suppression-test.c
> @@ -102,3 +102,4 @@ static struct kunit_suite backtrace_suppression_test_suite = {
>  kunit_test_suites(&backtrace_suppression_test_suite);
>
>  MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("KUnit test to verify warning backtrace suppression");
> --
> 2.34.1
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5281 bytes)