linux-kernel - Re: [PATCH] kunit: fixes Compilation error on s390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABVgOS=CmT-=opimA0Yq3S=VpPYb-4UXYZqpr=LTFQBybomnww@mail.gmail.com>
Date: Sun, 30 Mar 2025 13:12:11 +0800
From: David Gow <davidgow@...gle.com>
To: Alessandro Carminati <acarmina@...hat.com>
Cc: linux-kselftest@...r.kernel.org, Dan Carpenter <dan.carpenter@...aro.org>, 
	Daniel Diaz <daniel.diaz@...aro.org>, Arthur Grillo <arthurgrillo@...eup.net>, 
	Brendan Higgins <brendan.higgins@...ux.dev>, Naresh Kamboju <naresh.kamboju@...aro.org>, 
	Andrew Morton <akpm@...ux-foundation.org>, Maxime Ripard <mripard@...nel.org>, 
	Ville Syrjala <ville.syrjala@...ux.intel.com>, Daniel Vetter <daniel@...ll.ch>, 
	Guenter Roeck <linux@...ck-us.net>, Alessandro Carminati <alessandro.carminati@...il.com>, 
	Jani Nikula <jani.nikula@...el.com>, Shuah Khan <skhan@...uxfoundation.org>, 
	Mickael Salaun <mic@...ikod.net>, Kees Cook <kees@...nel.org>, 
	Stephen Rothwell <sfr@...b.auug.org.au>, dri-devel@...ts.freedesktop.org, 
	kunit-dev@...glegroups.com, linux-arch@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org, 
	linux-next@...r.kernel.org
Subject: Re: [PATCH] kunit: fixes Compilation error on s390

On Sat, 29 Mar 2025 at 23:04, Alessandro Carminati <acarmina@...hat.com> wrote:
>
> The current implementation of suppressing warning backtraces uses __func__,
> which is a compile-time constant only for non -fPIC compilation.
> GCC's support for this situation in position-independent code varies across
> versions and architectures.
>
> On the s390 architecture, -fPIC is required for compilation, and support
> for this scenario is available in GCC 11 and later.
>
> Fixes:  d8b14a2 ("bug/kunit: core support for suppressing warning backtraces")
>
> Signed-off-by: Alessandro Carminati <acarmina@...hat.com>
> ---

Makes sense and seems to work here. Thanks!

Acked-by: David Gow <davidgow@...gle.com>

Cheers,
-- David


>  lib/kunit/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/kunit/Kconfig b/lib/kunit/Kconfig
> index 201402f0ab49..6c937144dcea 100644
> --- a/lib/kunit/Kconfig
> +++ b/lib/kunit/Kconfig
> @@ -17,6 +17,7 @@ if KUNIT
>
>  config KUNIT_SUPPRESS_BACKTRACE
>         bool "KUnit - Enable backtrace suppression"
> +       depends on (!S390 && CC_IS_GCC) || (CC_IS_GCC && GCC_VERSION >= 110000)
>         default y
>         help
>           Enable backtrace suppression for KUnit. If enabled, backtraces
> --
> 2.34.1
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5281 bytes)