linux-kernel - Re: [PATCH] clk: ti: Simplify ti_find_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250331115329.605ba522@akair>
Date: Mon, 31 Mar 2025 11:53:29 +0200
From: Andreas Kemnade <andreas@...nade.info>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Tero Kristo <kristo@...nel.org>, Michael Turquette
 <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>,
 linux-omap@...r.kernel.org, linux-clk@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: ti: Simplify ti_find_clock_provider()

Am Wed, 12 Mar 2025 11:33:30 -0500
schrieb "Rob Herring (Arm)" <robh@...nel.org>:

> Remove using for_each_of_allnodes_from() which is not safe to use
> without holding the DT spinlock. In reality that probably doesn't
> matter here. This is the only user in the whole tree, so it can be
> made private once removed here. The "from" argument is always NULL, so
> it can be dropped as well.
> 
> There's a slight change in behavior in matching the "clock-output-names"
> value as the prior code would match if the node name matched the
> beginning of the value and the comparision was case insensitive. Now
> it must be an exact match.
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
> Compiled only. I'm not sure if the the change in behavior is going to 
> matter. 
> 
did some testing. Nothing odd seen at the platforms I tested but I feel
a bit uncomfortable with
https://lore.kernel.org/linux-clk/20240925100603.4cba9176@akair/
in combination with this.

Regards,
Andreas