linux-kernel - Re: [PATCH 1/4] drm: adp: Replace custom compare_dev with component_compare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250331113431.GB246397@robin.jannau.net>
Date: Mon, 31 Mar 2025 13:34:31 +0200
From: Janne Grunau <j@...nau.net>
To: shao.mingyin@....com.cn
Cc: liviu.dudau@....com, chunkuang.hu@...nel.org, fnkl.kernel@...il.com,
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
	airlied@...il.com, simona@...ll.ch, dri-devel@...ts.freedesktop.org,
	asahi@...ts.linux.dev, linux-kernel@...r.kernel.org,
	p.zabel@...gutronix.de, matthias.bgg@...il.com,
	angelogioacchino.delregno@...labora.com,
	linux-mediatek@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, yang.yang29@....com.cn,
	xu.xin16@....com.cn, ye.xingchen@....com.cn,
	tang.dongxing@....com.cn, tzimmermann@...e.de
Subject: Re: [PATCH 1/4] drm: adp: Replace custom compare_dev with component_compare_of

On Mon, Mar 31, 2025 at 05:28:45PM +0800, shao.mingyin@....com.cn wrote:
> From: Tang Dongxing <tang.dongxing@....com.cn>
> 
> Remove the custom device comparison function compare_dev and replace it
> with the existing kernel helper component_compare_of
> 
> Signed-off-by: Tang Dongxing <tang.dongxing@....com.cn>
> Signed-off-by: Shao Mingyin <shao.mingyin@....com.cn>
> ---
>  drivers/gpu/drm/adp/adp_drv.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/adp/adp_drv.c b/drivers/gpu/drm/adp/adp_drv.c
> index c98c647f981d..32350c1a5c1f 100644
> --- a/drivers/gpu/drm/adp/adp_drv.c
> +++ b/drivers/gpu/drm/adp/adp_drv.c
> @@ -551,11 +551,6 @@ static const struct component_master_ops adp_master_ops = {
>  	.unbind = adp_drm_unbind,
>  };
> 
> -static int compare_dev(struct device *dev, void *data)
> -{
> -	return dev->of_node == data;
> -}
> -
>  static int adp_probe(struct platform_device *pdev)
>  {
>  	struct device_node *port;
> @@ -579,7 +574,7 @@ static int adp_probe(struct platform_device *pdev)
>  	if (!port)
>  		return -ENODEV;
> 
> -	drm_of_component_match_add(&pdev->dev, &match, compare_dev, port);
> +	drm_of_component_match_add(&pdev->dev, &match, component_compare_of, port);
>  	of_node_put(port);
> 
>  	return component_master_add_with_match(&pdev->dev, &adp_master_ops, match);

Reviewied-by: Janne Grunau <j@...nau.net>

thanks,
Janne