[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Z-xWe6nHEvKHdvsd@e110455-lin.cambridge.arm.com>
Date: Tue, 1 Apr 2025 22:11:23 +0100
From: Liviu Dudau <liviu.dudau@....com>
To: shao.mingyin@....com.cn
Cc: j@...nau.net, chunkuang.hu@...nel.org, fnkl.kernel@...il.com,
maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch,
dri-devel@...ts.freedesktop.org, asahi@...ts.linux.dev,
linux-kernel@...r.kernel.org, p.zabel@...gutronix.de,
matthias.bgg@...il.com, angelogioacchino.delregno@...labora.com,
linux-mediatek@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org, yang.yang29@....com.cn,
xu.xin16@....com.cn, ye.xingchen@....com.cn,
tang.dongxing@....com.cn
Subject: Re: [PATCH 2/4] drm: arm: hdlcd: Replace custom compare_dev with component_compare_of
On Mon, Mar 31, 2025 at 05:30:18PM +0800, shao.mingyin@....com.cn wrote:
> From: Tang Dongxing <tang.dongxing@....com.cn>
>
> Remove the custom device comparison function compare_dev and replace it
> with the existing kernel helper component_compare_of
>
> Signed-off-by: Tang Dongxing <tang.dongxing@....com.cn>
> Signed-off-by: Shao Mingyin <shao.mingyin@....com.cn>
Reviewed-by: Liviu Dudau <liviu.dudau@....com>
Best regards,
Liviu Dudau
> ---
> drivers/gpu/drm/arm/hdlcd_drv.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c
> index c3179d74f3f5..45b1dc5613bf 100644
> --- a/drivers/gpu/drm/arm/hdlcd_drv.c
> +++ b/drivers/gpu/drm/arm/hdlcd_drv.c
> @@ -346,11 +346,6 @@ static const struct component_master_ops hdlcd_master_ops = {
> .unbind = hdlcd_drm_unbind,
> };
>
> -static int compare_dev(struct device *dev, void *data)
> -{
> - return dev->of_node == data;
> -}
> -
> static int hdlcd_probe(struct platform_device *pdev)
> {
> struct device_node *port;
> @@ -361,7 +356,7 @@ static int hdlcd_probe(struct platform_device *pdev)
> if (!port)
> return -ENODEV;
>
> - drm_of_component_match_add(&pdev->dev, &match, compare_dev, port);
> + drm_of_component_match_add(&pdev->dev, &match, component_compare_of, port);
> of_node_put(port);
>
> return component_master_add_with_match(&pdev->dev, &hdlcd_master_ops,
> --
> 2.25.1
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
Powered by blists - more mailing lists