linux-kernel - Re: [PATCH v4] mm/page_alloc: Consolidate unlikely handling in page_expected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8720c775-c0fb-4fbf-a1a8-409fef2b67ad@linux.dev>
Date: Mon, 31 Mar 2025 20:08:01 +0800
From: Ye Liu <ye.liu@...ux.dev>
To: Matthew Wilcox <willy@...radead.org>
Cc: akpm@...ux-foundation.org, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, Markus.Elfring@....de,
 Ye Liu <liuye@...inos.cn>, Sidhartha Kumar <sidhartha.kumar@...cle.com>,
 Anshuman Khandual <anshuman.khandual@....com>
Subject: Re: [PATCH v4] mm/page_alloc: Consolidate unlikely handling in
 page_expected_state


在 2025/3/28 22:29, Matthew Wilcox 写道:
> On Fri, Mar 28, 2025 at 09:47:57AM +0800, Ye Liu wrote:
>> Consolidate the handling of unlikely conditions in the 
>> page_expected_state() function to reduce code duplication and improve 
>> readability.
> I don't think this is an equivalent transformation.
Could you explain it in detail?
> Please, stop with these tweaky patches to incredibly sensitive core code.
> Fix a problem, or leave it alone.  We are primarily short of reviewer
> bandwidth.  You could help with that by reviewing other people's patches.
> Sending patches of your own just adds to other people's workload.
Thank you for your feedback. I understand the sensitivity of core code
and respect the limitations on reviewer bandwidth. However, I believe
that reasonable optimizations should not be rejected solely because
they involve core code. If an improvement enhances performance,
readability, or maintainability without introducing risks, wouldn't
it be worth considering for review?

Regarding the reviewer shortage, I’d be happy to help by reviewing
other patches as well. Could you please share the process for becoming
a reviewer? What are the requirements or steps to get involved?

Additionally, I’d like to clarify that my intention in submitting
patches is to improve the project, not to create unnecessary workload
for others. If there’s a better way for me to contribute, please let
me know I'm more than willing to collaborate.                         


Thanks,
 Ye Liu