linux-kernel - Re: [PATCH v2] intel_th: avoid using deprecated page->mapping, index fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77e9246c-5976-4661-a397-21776db3584e@lucifer.local>
Date: Mon, 31 Mar 2025 13:08:43 +0100
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Matthew Wilcox <willy@...radead.org>, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, David Hildenbrand <david@...hat.com>
Subject: Re: [PATCH v2] intel_th: avoid using deprecated page->mapping, index
 fields

On Mon, Mar 31, 2025 at 02:01:38PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Mar 31, 2025 at 12:59:36PM +0100, Lorenzo Stoakes wrote:
> > +cc Greg
> >
> > On Mon, Mar 31, 2025 at 09:36:40AM +0300, Alexander Shishkin wrote:
> > > Matthew Wilcox <willy@...radead.org> writes:
> > >
> > > > On Wed, Jan 29, 2025 at 01:39:06PM +0200, Alexander Shishkin wrote:
> > > >> Lorenzo Stoakes <lorenzo.stoakes@...cle.com> writes:
> > > >>
> > > >> > Thanks very much! Yeah just keen to get this in as we are moving towards
> > > >> > removing these fields very soon.
> > > >>
> > > >> My understanding is that this is a part of larger effort to reduce
> > > >> struct page to 8 bytes and an optionally dynamically allocated slightly
> > > >> larger structure, is that correct? Just curious.
> > > >>
> > > >> > Could you take this in your tree? I think that'd work best.
> > > >>
> > > >> Sure, will do.
> > > >
> > > > Hi, this doesn't appear to be in linux-next yet.  Could you confirm it's
> > > > scheduled to hit the next merge window?
> > >
> > > Yes, I'll send it to Greg once -rc1 is tagged.
> >
> > Right, is this ultimately handled in Greg's PR? Did you not send to him
> > ready for the merge window?
> >
> > Or did you? I'm confused.
>
> I don't see it in my tree right now, is it in linux-next?  Nope, don't
> see it there either :(

Yup... we did ask about this, quite a few times :)

Can you take direct, if you typically handle these from Alex?

>
> > We do really need this merged for 6.15, can we make sure this actually
> > lands? You did confirm it'd go in 2 months ago, and the patch was sent 4
> > months ago, and we have been chasing this repeatedly.
> >
> > For reference, patch is [0].
> >
> > [0]: https://lore.kernel.org/all/20241203080001.12341-1-lorenzo.stoakes@oracle.com/
>
> What changes in 6.15 to require this then?  If it's a bugfix for older
> kernels too, why isn't it tagged for stable inclusion as well?

We're removing page->mapping, index, not required for stable inclusion. This is
a hold-up to a critical mm change, once of many such changes.

We have confirmation from Alex this is fine and he agreed to send in _this_
merge window well in advance of it [1].

So I don't think there's any reason not to send, it's just for whatever reason
not happened...

[1]: https://lore.kernel.org/all/87v7tyyrvb.fsf@ubik.fi.intel.com/

>
> thanks,
>
> greg k-h

Thanks, Lorenzo