lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHCN7x+WkhPQGLUqJ40SjtmhTXx=Fn2rkqw8NQ=qgaNnpK97zQ@mail.gmail.com>
Date: Mon, 31 Mar 2025 08:45:26 -0500
From: Adam Ford <aford173@...il.com>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: Dominique Martinet <dominique.martinet@...ark-techno.com>, Vinod Koul <vkoul@...nel.org>, 
	Kishon Vijay Abraham I <kishon@...nel.org>, Frieder Schrempf <frieder.schrempf@...tron.de>, 
	Marco Felsch <m.felsch@...gutronix.de>, Lucas Stach <l.stach@...gutronix.de>, 
	linux-phy@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	Makoto Sato <makoto.sato@...ark-techno.com>
Subject: Re: [PATCH] phy: freescale: fsl-samsung-hdmi: return closest rate
 instead LUT

On Mon, Mar 10, 2025 at 11:12 AM Uwe Kleine-König
<u.kleine-koenig@...libre.com> wrote:
>
> Hello Dominique,
>
> On Mon, Mar 10, 2025 at 06:48:50PM +0900, Dominique Martinet wrote:
> > [...] and I'm sure there are other improvements that could be made at
> > the edges.
>
> One thing that irritated me is the function names. `phy_clk_round_rate`
> sounds too generic. `fsl_samsung_hdmi_phy_clk_round_rate` is long, but
> I'd say would be a better match.

If Dominique won't have time, I can try to clean this up a bit.  I was
not liking the names either, but I was trying to keep them small.
I'll default to this convention more in the future, based on your
feedback.

adam
>
> Best regards
> Uwe

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ