linux-kernel - Re: [PATCH v1 1/1] hwmon: (qnap-mcu) Remove (explicitly) unused header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c4b467ec-471f-4cf8-9666-17db6284d26b@roeck-us.net>
Date: Mon, 31 Mar 2025 06:53:53 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Heiko Stuebner <heiko@...ech.de>, linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org, Jean Delvare <jdelvare@...e.com>
Subject: Re: [PATCH v1 1/1] hwmon: (qnap-mcu) Remove (explicitly) unused
 header

On Mon, Mar 31, 2025 at 10:06:00AM +0300, Andy Shevchenko wrote:
> The fwnode.h is not supposed to be used by the drivers as it
> has the definitions for the core parts for different device
> property provider implementations. Drop it.
> 
> Note, that fwnode API for drivers is provided in property.h
> which is included here.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/qnap-mcu-hwmon.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hwmon/qnap-mcu-hwmon.c b/drivers/hwmon/qnap-mcu-hwmon.c
> index 29057514739c..e86e64c4d391 100644
> --- a/drivers/hwmon/qnap-mcu-hwmon.c
> +++ b/drivers/hwmon/qnap-mcu-hwmon.c
> @@ -6,7 +6,6 @@
>   * Copyright (C) 2024 Heiko Stuebner <heiko@...ech.de>
>   */
>  
> -#include <linux/fwnode.h>
>  #include <linux/hwmon.h>
>  #include <linux/mfd/qnap-mcu.h>
>  #include <linux/module.h>