linux-kernel - Re: [PATCH]hwmon: (k10temp) Add support for Zen5 Ryzen Desktop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f9ecd621-0a12-46b6-a4d8-7714f65da58a@roeck-us.net>
Date: Mon, 31 Mar 2025 06:55:08 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: David Hows <david@...s.id.au>, Clemens Ladisch <clemens@...isch.de>,
 Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH]hwmon: (k10temp) Add support for Zen5 Ryzen Desktop

On 3/27/25 17:37, David Hows wrote:
> Add support for retrieving CCD temperatures on Granite Ridge Ryzen Desktop CPUs
> 
> Tested locally against my 9950X3D CPU.

checkpatch:

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#50:
Add support for retrieving CCD temperatures on Granite Ridge Ryzen Desktop CPUs

ERROR: Missing Signed-off-by: line(s)

> ---
>   drivers/hwmon/k10temp.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
> index d0b4cc9a5011..cc2ad7a324f9 100644
> --- a/drivers/hwmon/k10temp.c
> +++ b/drivers/hwmon/k10temp.c
> @@ -502,6 +502,13 @@ static int k10temp_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>   			k10temp_get_ccd_support(data, 12);
>   			break;
>   		}
> +	} else if (boot_cpu_data.x86 == 0x1a) {
> +		switch (boot_cpu_data.x86_model) {
> +		case 0x40 ... 0x4f:	/* Zen5 Ryzen Desktop*/
> +			data->ccd_offset = 0x308;
> +			k10temp_get_ccd_support(data, 8);
> +			break;
> +		}
>   	}
>   
>   	for (i = 0; i < ARRAY_SIZE(tctl_offset_table); i++) {